1849882 - LanguageSwitcher.jsx: ESLint warnings of React Hook useEffect has missing dependencies

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P3)

Description

[Mark Banner (:standard8)]

When we turn on ESLint warnings on LanguageSwitcher.jsx, we see various warnings being referenced:

./mach eslint --warnings browser/components/newtab/content-src/aboutwelcome/components/LanguageSwitcher.jsx
  113:5  warning  React Hook useEffect has a missing dependency: 'screen'. Either include it or remove the dependency array.                                                                                                                                                                                                                                       react-hooks/exhaustive-deps (eslint)
  137:5  warning  React Hook useEffect has missing dependencies: 'appAndSystemLocaleInfo?.matchType', 'languageMismatchScreenIndex', 'screen', 'screenIndex', and 'setScreenIndex'. Either include them or remove the dependency array. If 'setScreenIndex' changes too often, find the parent component that defines it and wrap that definition in useCallback.  react-hooks/exhaustive-deps (eslint)
  175:6  warning  React Hook useEffect has missing dependencies: 'handleAction' and 'negotiatedLanguage.requestSystemLocales'. Either include them or remove the dependency array.                                                                                                                                                                                 react-hooks/exhaustive-deps (eslint)

I'm not sure if these should be added or excluded. I would like to make this rule into an error so that we can be sure these are addressed.

Ed, I think you added most of these, can you take a look please?

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1849882 - Add more useEffect dependencies to language switcher r=emcminn

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e7a9611e91
Add more useEffect dependencies to language switcher r=emcminn

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a8e7a9611e91