With the addition of translation icon, we have been seeing overlaps of reader mode icons and translate icons many a times. Today with this PR https://phabricator.services.mozilla.com/D205105#inline-1137122, we have come up with more of a hacky solution which works. But we need to revisit this and dig deep as to how we can improve the functionality to not cause this issue. Steps to replicate, would be to 1. make sure translation feature are enabled. 2. Open a wikipedia page in a different language than your system language which causes translation icon to show up. 3. Continue keep pressing links within and it ultimately causes the overlap. Attaching the screenshot.
Bug 1888516 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
With the addition of translation icon, we have been seeing overlaps of reader mode icons and translate icons many a times. Today with this PR https://phabricator.services.mozilla.com/D205105#inline-1137122, we have come up with more of a hacky solution which works. But we need to revisit this and dig deep as to how we can improve the functionality to not cause this issue. Steps to replicate, would be to 1. make sure translation feature are enabled. 2. Open a wikipedia page in a different language than your system language which causes translation icon to show up. 3. Keep pressing links within and it ultimately causes the overlap. Attaching the screenshot.