The toolbar redesign expects the navbar only be present for phones in portrait mode. It means we are running into situations when the navbar has been added and we should remove it on configuration change, as well as we would have to add it on a configuration change. Extracting the part of the initializeUI/onCreateView function that initializes navBar classes into a separate function will allow as to call the same code on the configuration change when we need to add the navBar again.
Bug 1890218 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
The toolbar redesign expects the navbar only be present for phones in portrait mode. It means we are running into situations when the navbar has been added and we should remove it on configuration change, as well as we would have to add it on a configuration change. Extracting the part of the initializeUI/onCreateView function that initializes navBar classes into a separate function will allow as to call the same code on the configuration change when we need to add the navBar again. Refactoring requested during https://phabricator.services.mozilla.com/D206577 review