Closed
Bug 1890218
Opened 11 months ago
Closed 11 months ago
[toolbar redesign] refactor navbar init into a separate function
Categories
(Fenix :: Toolbar, task)
Tracking
(firefox126 fixed)
RESOLVED
FIXED
126 Branch
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: mavduevskiy, Assigned: mavduevskiy)
References
Details
Attachments
(1 file)
The toolbar redesign expects the navbar only be present for phones in portrait mode. It means we are running into situations when the navbar has been added and we should remove it on configuration change, as well as we would have to add it on a configuration change. Extracting the part of the initializeUI/onCreateView function that initializes navBar classes into a separate function will allow as to call the same code on the configuration change when we need to add the navBar again.
Refactoring requested during https://phabricator.services.mozilla.com/D206577 review
|
Assignee | |
Updated•11 months ago
|
Assignee: nobody → mavduevskiy
|
|
Assignee | |
Comment 1•11 months ago
|
||
|
||
Updated•11 months ago
|
Attachment #9395444 -
Attachment description: Bug 1890218 - Extract NavBar initialization into a separate function → Bug 1890218 - Refactor NavBar initialization into a separate function
|
|
Assignee | |
Updated•11 months ago
|
Summary: [toolbar redesign] extract navbar init into a separate function → [toolbar redesign] refactor navbar init into a separate function
Pushed by mavduevskiy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7503af14935b
Refactor NavBar initialization into a separate function r=android-reviewers,skhan
|
||
Comment 4•11 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox126:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•