tl;dr: The test probably just needs a fuzzy annotation for linux, similar to the existing fuzzy annotation for Windows and mac. Currently it's expecting the testcase/reference to precisely match, only on linux, but that doesn't really make sense because the testcase and reference case are asking for different icons. (Maybe/probably on our test runners, the icon set used to be relatively-limited and the icons were in fact the same, at least when requested at the 16px size that we're suing here; but that's no longer the case, I guess?) Personally when I load the testcase locally on linux, the testcase and reference case render with different icons for me: * The testcase has `moz-icon://.txt?size=16` which for me is an icon that shows a document with lines of writing. * The reference has `moz-icon://bogus-unrecognized-icon.bogusunknown845?size=16` which renders similarly except with a question-mark instead of the lines of writing. * So: they're two completely different (albeit similar) system icons, I think. It looks like this test dates back to the patch in bug 1690845 (and it's been annotated as fuzzy-on-mac/windows as of when it landed, presumably due to an analogous difference on those platforms to what I'm seeing locally on Linux). I guess it never differed on our Linux test runners, but some infra change (possibly Bug 1888460) made us get a slightly different set of system-icons that are available (sometimes at least)? Anyway: given that the icons are still similar and still look ~reasonable for the corresponding file types (they're not wrong in a way that users might consider buggy as in bug 1690845), I'd suggest we just add a fuzzy annotation for linux, to allow for what we're seeing.
Bug 1894445 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
tl;dr: The test probably just needs a fuzzy annotation for linux, similar to the existing fuzzy annotation for Windows and mac. Currently it's expecting the testcase/reference to precisely match, only on linux, but that doesn't really make sense because the testcase and reference case are asking for different icons. (Maybe/probably on our test runners, the icon set used to be relatively-limited and the icons were in fact the same, at least when requested at the 16px size that we're using here; but that's no longer the case, I guess?) Personally when I load the testcase locally on linux, the testcase and reference case render with different icons for me: * The testcase has `moz-icon://.txt?size=16` which for me is an icon that shows a document with lines of writing. * The reference has `moz-icon://bogus-unrecognized-icon.bogusunknown845?size=16` which renders similarly except with a question-mark instead of the lines of writing. * So: they're two completely different (albeit similar) system icons, I think. It looks like this test dates back to the patch in bug 1690845 (and it's been annotated as fuzzy-on-mac/windows as of when it landed, presumably due to an analogous difference on those platforms to what I'm seeing locally on Linux). I guess it never differed on our Linux test runners, but some infra change (possibly Bug 1888460) made us get a slightly different set of system-icons that are available (sometimes at least)? Anyway: given that the icons are still similar and still look ~reasonable for the corresponding file types (they're not wrong in a way that users might consider buggy as in bug 1690845), I'd suggest we just add a fuzzy annotation for linux, to allow for what we're seeing.