We have a [group of reftests](https://searchfox.org/mozilla-central/rev/b41bb321fe4bd7d03926083698ac498ebec0accf/layout/reftests/async-scrolling/reftest.list#109,111,113-190) which test the interaction between `position:sticky` and dynamic toolbar movement. Most of them (the ones which actually simulate a dynamic toolbar offset) only run on Android. However, there does not appear to be a fundamental reason why these tests couldn't also run on desktop. Notably, they do not exercise any dynamic toolbar related code in GeckoView or android-components; rather, they simulate the effects of a dynamic toolbar offset on Layout and APZ code using some test-specific prefs. I was able to get these tests to work on desktop by making a very minimal change (removing [this #ifdef](https://searchfox.org/mozilla-central/rev/b41bb321fe4bd7d03926083698ac498ebec0accf/layout/painting/nsDisplayList.cpp#5825)). (And I found being able to run the test on desktop quite useful for debugging a failure caused by the draft patches in bug 1874199.) In this bug, I would like to get these tests to run on desktop in CI. This would have the advantage of providing test coverage for the relevant code on more platforms / catching regressions earlier, as well as making it easier to debug these tests locally on desktop.
Bug 1894555 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
We have a [group of reftests](https://searchfox.org/mozilla-central/rev/b41bb321fe4bd7d03926083698ac498ebec0accf/layout/reftests/async-scrolling/reftest.list#109,111,113-190) which test the interaction between `position:sticky` and dynamic toolbar movement. Most of them (the ones which actually simulate a dynamic toolbar offset) only run on Android. However, there does not appear to be a fundamental reason why these tests couldn't also run on desktop. Notably, they do not exercise any dynamic toolbar related code in GeckoView or android-components; rather, they simulate the effects of a dynamic toolbar offset on Layout and APZ code using some test-specific prefs. I was able to get these tests to work on desktop by making a very minimal change (removing [this #ifdef](https://searchfox.org/mozilla-central/rev/b41bb321fe4bd7d03926083698ac498ebec0accf/layout/painting/nsDisplayList.cpp#5825)). (And I found being able to run the test on desktop quite useful for debugging a failure caused by the draft patches in bug 1874199.) In this bug, I would like to get these tests to run on desktop in CI. This would have the advantage of providing test coverage for the relevant code on more platforms / catching regressions more easily during development, as well as making it easier to debug these tests locally on desktop.