1894555 - Run dynamic-toolbar-sticky-* tests on desktop

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

We have a group of reftests which test the interaction between position:sticky and dynamic toolbar movement.

Most of them (the ones which actually simulate a dynamic toolbar offset) only run on Android.

However, there does not appear to be a fundamental reason why these tests couldn't also run on desktop. Notably, they do not exercise any dynamic toolbar related code in GeckoView or android-components; rather, they simulate the effects of a dynamic toolbar offset on Layout and APZ code using some test-specific prefs.

I was able to get these tests to work on desktop by making a very minimal change (removing this #ifdef). (And I found being able to run the test on desktop quite useful for debugging a failure caused by the draft patches in bug 1874199.)

In this bug, I would like to get these tests to run on desktop in CI. This would have the advantage of providing test coverage for the relevant code on more platforms / catching regressions more easily during development, as well as making it easier to debug these tests locally on desktop.

Comment 1

[Botond Ballo [:botond]]

(I'll make this change after bug 1874199 just for code dependency reasons; there isn't a conceptual dependency between the two.)

Comment 2

[Botond Ballo [:botond]]

Generalizing this slightly, as we might as well do this for the dynamic-toolbar-fixed-* tests as well.

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1894555 - Run dynamic-toolbar-sticky-* tests on desktop as well. r=dlrobertson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49e49d8da627
Run dynamic-toolbar-{fixed,sticky}-* tests on desktop as well. r=dlrobertson

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for crashes on mochitest.toml

Backout link: https://hg.mozilla.org/integration/autoland/rev/4e9d8ba3895bef38c42eddb57c7e6e1ec49085b2
Log link: https://treeherder.mozilla.org/logviewer?job_id=456904164&repo=autoland&lineNumber=4622

There were also geckoview-junit failures

Comment 6

[Botond Ballo [:botond]]

Looks like the failures are caused by the position:fixed changes in particular.

I'm going to narrow the scope of the bug back to just position:sticky, and deal with position:fixed in a follow-up bug.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fcb0e1a3461
Run dynamic-toolbar-sticky-* tests on desktop as well. r=dlrobertson

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9fcb0e1a3461

Comment 9

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #6)

I'm going to narrow the scope of the bug back to just position:sticky, and deal with position:fixed in a follow-up bug.

The follow-up is bug 1895396.