Bug 1901261 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Some follow up based on our discussion yesterday:
- Exposure
  - As long as this is registered as a new feature in [FeatureManifest.yaml](https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml), exposure should be recorded [here in ASRouter's sendTriggerMessage](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/ASRouter.sys.mjs#2058).
- Impressions for ASRouter
  - By passing `dispatchCFRAction` to the new surface (like we do [here for Infobar](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/ASRouter.sys.mjs#1446-1451)) we can use it to record impressions for use in frequency capping (like [here](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/InfoBar.sys.mjs#75-77)) to ensure caps are honored and the button isn't added multiple times.
- Impression for Telemetry
  - I think we will want to capture a single impression whenever a button is added via a message. You can add a call to record an impression telemetry event using the same `dispatchCFRAction` from above, like in [this Infobar example](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/InfoBar.sys.mjs#75-77).
- Data Review / Adding Telemetry 
  - We'll need to update TelemetryFeed.sys.mjs to include user events from the new surface. Searching the file for "infobar" provides a good example. 
  - See bug 1685525 for the accompanying data request for Infobar, similar to what will also be required for registering user events for this new surface.
- Dismiss/Remove events
  - As of yet, I haven't found where the removal of toolbar widgets is recorded as part of BrowserUsageTelemetry. We can record "DISMISS" events in a similar way to how recording impressions is described above (similar to [here in Infobar](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/InfoBar.sys.mjs#110)).
Some follow up based on our discussion yesterday:
- Exposure
  - As long as this is registered as a new feature in [FeatureManifest.yaml](https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml), exposure should be recorded [here in ASRouter's sendTriggerMessage](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/ASRouter.sys.mjs#2058).
- Impressions for ASRouter
  - By passing `dispatchCFRAction` to the new surface (like we do [here for Infobar](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/ASRouter.sys.mjs#1446-1451)) we can use it to record impressions for use in frequency capping (like [here](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/InfoBar.sys.mjs#75-77)) to ensure caps are honored and the button isn't added multiple times.
- Impression for Telemetry
  - I think we will want to capture a single impression whenever a button is added via a message. You can add a call to record an impression telemetry event using the same `dispatchCFRAction` from above, like in [this Infobar example](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/InfoBar.sys.mjs#75-77). Alternatively, we may be able to add an "added" event via browser.ui.interaction (see comment below). 
- Data Review / Adding Telemetry 
  - We'll need to update TelemetryFeed.sys.mjs to include user events from the new surface. Searching the file for "infobar" provides a good example. 
  - See bug 1685525 for the accompanying data request for Infobar, similar to what will also be required for registering user events for this new surface.
- Dismiss/Remove events
  - As of yet, I haven't found where the removal of toolbar widgets is recorded as part of BrowserUsageTelemetry. We can record "DISMISS" events in a similar way to how recording impressions is described above (similar to [here in Infobar](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/InfoBar.sys.mjs#110)). Alternatively, we can add a "removed" event in browser.ui.interaction (again, see comment below).

If we do go the route of updating browser.ui.interaction to capture the "added"/"removed" events, there's an example data review request in [this patch](https://bugzilla.mozilla.org/show_bug.cgi?id=1620358) that might be useful for reference.
Some follow up based on our discussion yesterday:
- Exposure
  - As long as this is registered as a new feature in [FeatureManifest.yaml](https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml), exposure should be recorded [here in ASRouter's sendTriggerMessage](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/ASRouter.sys.mjs#2058).
- We will want to capture impressions for ASRouter to honor frequency caps
- Impression for Telemetry
  - We can use an existing "added" event via browser.ui.interaction (see [comments below](https://bugzilla.mozilla.org/show_bug.cgi?id=1901261#c4)). 
- Data Review / Adding Telemetry 
  - If we ended needing any new telemetry, we can update TelemetryFeed.sys.mjs to include user events from the new surface. Searching the file for "infobar" provides a good example. See bug 1685525 for the accompanying data request for Infobar, similar to what will also be required for registering user events for this new surface.
- Dismiss/Remove events
  - ~~We can record "DISMISS" events in a similar way to how recording impressions is described above (similar to [here in Infobar](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/InfoBar.sys.mjs#110)). Alternatively, we may be able to use a "removed" event in browser.ui.interaction or add one.
 - If we do go the route of updating browser.ui.interaction to capture the new events, there's an example data review request in [this patch](https://bugzilla.mozilla.org/show_bug.cgi?id=1620358) that might be useful for reference.
Some follow up based on our discussion yesterday:
- Exposure
  - As long as this is registered as a new feature in [FeatureManifest.yaml](https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml), exposure should be recorded [here in ASRouter's sendTriggerMessage](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/ASRouter.sys.mjs#2058).
- We will want to capture impressions for ASRouter to honor frequency caps
- Impression for Telemetry
  - We can use an existing "added" event via browser.ui.interaction (see [comments below](https://bugzilla.mozilla.org/show_bug.cgi?id=1901261#c4)). 
- Data Review / Adding Telemetry 
  - If we ended needing any new telemetry, we can update TelemetryFeed.sys.mjs to include user events from the new surface. Searching the file for "infobar" provides a good example. See bug 1685525 for the accompanying data request for Infobar, similar to what will also be required for registering user events for this new surface.
- Dismiss/Remove events
  - ~~We can record "DISMISS" events in a similar way to how recording impressions is described above (similar to [here in Infobar](https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/InfoBar.sys.mjs#110)).~~ Alternatively, we may be able to use a "removed" event in browser.ui.interaction or add one.
 - If we do go the route of updating browser.ui.interaction to capture the new events, there's an example data review request in [this patch](https://bugzilla.mozilla.org/show_bug.cgi?id=1620358) that might be useful for reference.

Back to Bug 1901261 Comment 2