1685525 - Update or add a trigger capable of targeting newtab/homepage for messages

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

We need a trigger for about:newtab/home if we ever want to show messages apart from snippets on this page. Maybe by integrating AboutNewTabParent <-> and TriggerListeners in a way similar to the DefaultBrowserNotification.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Bug 1685525 - fix an issue with selectedBrowser now works for CFRs too

Depends on D100917

Comment 4

[Andrei Oprea [:andreio]]

Attachment: Bug 1685525 - Idea to allow snippets and infobars to coexist on the newtab page

Depends on D101595

Comment 5

[Phabricator Automation]

Comment on attachment 9196824 [details]
Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages

Revision D100917 was moved to bug 1685266. Setting attachment 9196824 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9196824 [details]
Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages

Revision D100917 was moved to bug 1685266. Setting attachment 9196824 [details] to obsolete.

Comment 7

[Andrei Oprea [:andreio]]

Attachment: Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages

Comment 8

[Andrei Oprea [:andreio]]

Attachment: data_review_request_1685525.txt

Comment 9

[Tim Smith 👨‍🔬 [:tdsmith]]

Comment on attachment 9200105 [details]
data_review_request_1685525.txt

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, at https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/v2-system-addon/data_events.html.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nan.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Cat 2, interaction data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent collection.

9. Does the data collection use a third-party collection tool?

No.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57c61d78ae53
Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson

Comment 11

[Atila Butkovits]

Backed out for causing failures on browser_asrouter_trigger_docs.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b6ef3a39ab6cd5e37429fa0c9ffd32ccd6ebeff3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=VPfALsuqRIa9M34n5aQOVw.0&revision=57c61d78ae5349595c46d2b4ad465e3fbca12a43&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc17

First failure log: https://treeherder.mozilla.org/logviewer?job_id=328471045&repo=autoland&lineNumber=2394
Second failure log: https://treeherder.mozilla.org/logviewer?job_id=328469438&repo=autoland&lineNumber=17412

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9464e66648e3
Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson

Comment 13

[Atila Butkovits]

Backed out for node failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/34fef45f00d0e8115d627a38bde5bfd6b105c7ed

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=GcyqGRWnQ3WtLmmGYU-cFA.0&searchStr=linux%2C18.04%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-newtab-unit-tests%2Cnewtab&revision=9464e66648e3857aee5e342b12295803aa6e6ea7

Failure log: https://treeherder.mozilla.org/logviewer?job_id=328486066&repo=autoland&lineNumber=383

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b783e4113b8a
Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b783e4113b8a

Comment 16

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: We want to run an experiment that shows an InfoBar for setting the default browser (similar to previous bug 1668861 except now it can show on any tab) which requires changes to prevent the existing modal prompt from showing when Firefox starts.

Comment 17

[Andrei Oprea [:andreio]]

Comment on attachment 9197363 [details]
Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages

Beta/Release Uplift Approval Request

• User impact if declined: Prevent from running Set default browser experiment https://mana.mozilla.org/wiki/pages/viewpage.action?pageId=130918595
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by tests. Feature is enabled remotely via experiment.
  QA testing was covered in 1690735
• String changes made/needed:

Comment 18

[Pascal Chevrel:pascalc]

Comment on attachment 9197363 [details]
Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages

Approved for 86 beta 7, thanks.

Comment 19

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3b9ec5f1b845