Bug 1901308 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Normally, we would avoid password requirement issues before we can even call `BackupService.enableEncryption`. However, there is a possibility that something goes awry anyways while trying to enable encryption. Therefore, we should:
- Catch any potential errors and visually display an error on the turn-on dialog
- Ensure that the turn-on dialog does *not* close until the user tries again without issue, or until they press the Cancel button

Similarly for `BackupService.setParentDirPath`, the function may be supplied a invalid folder or a folder that was deleted before confirming dialog options. We likely want to:
- Catch invalid file paths and visually display an error on the turn-on dialog
- Ensure that the turn-on dialog does *not* close until the user chooses another folder, or until they press the Cancel button

We expect this feature to be tested and have an entry in Storybook.
**Enabling Encryption**
Normally, we would avoid password requirement issues before we can even call `BackupService.enableEncryption`. However, there is a possibility that something goes awry anyways during this step. Therefore, we should:
- Catch any potential errors and visually display an error message
- If an error was caught from a dialog (ex. "turn on", "add password" dialogs), we likely want to *keep the dialog open* until the user tries again without issue, or until they press the Cancel button

**Disabling Encryption**
In the rare situation where we attempt to disable encryption for a backup that was never encrypted in the first place, we throw an error. It's not known at the moment if we really want to show an error or not.

**Setting Parent Dir**
For `BackupService.setParentDirPath`, the function may be supplied a invalid folder or a folder that was deleted before confirming dialog options. We likely want to:
- Catch invalid file paths and visually display an error on the caller widget (turn on dialog, or backup-settings)
- If the caller widget is a dialog, do *not close* it until the user chooses another folder, or until they press the Cancel button

We expect this feature to be tested and have an entry in Storybook.

Back to Bug 1901308 Comment 0