1901308 - Display an error in the turn-on dialog if there are issues with toggling encryption or setting the parent directory

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[kpatenio]

Enabling Encryption
Normally, we would avoid password requirement issues before we can even call BackupService.enableEncryption. However, there is a possibility that something goes awry anyways during this step. Therefore, we should:

• Catch any potential errors and visually display an error message
• If an error was caught from a dialog (ex. "turn on", "add password" dialogs), we likely want to keep the dialog open until the user tries again without issue, or until they press the Cancel button

Disabling Encryption
In the rare situation where we attempt to disable encryption for a backup that was never encrypted in the first place, we throw an error. It's not known at the moment if we really want to show an error or not.

Setting Parent Dir
For BackupService.setParentDirPath, the function may be supplied a invalid folder or a folder that was deleted before confirming dialog options. We likely want to:

• Catch invalid file paths and visually display an error on the caller widget (turn on dialog, or backup-settings)
• If the caller widget is a dialog, do not close it until the user chooses another folder, or until they press the Cancel button

We expect this feature to be tested and have an entry in Storybook.

Comment 1

[kpatenio]

Cross-posting mconley's review comment from Phabricator:

in the event that there's an error here, we're likely going to want to display that in the turn-on-scheduled-backups dialog, which means keeping it open until enabling resolves. So we might need to adjust this to use a sendQuery from the child actor, and not close the dialog until a positive response is received.

Comment 2

[Stephen Thompson]

Attachment: Bug 1901308 - Show profile backup errors and keep modals open r=#backup-reviewers!

Currently, clicking "confirm" buttons on modals in the profile backup settings menu will always close the modals regardless of whether the operation succeeded or failed. In the case of errors, users don't know that something went wrong. It's better to keep the modals open and display an error so that the user knows what to do next and can try to fix the issue, if applicable.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd72ed21a114
Show profile backup errors and keep modals open r=backup-reviewers,fluent-reviewers,firefox-desktop-core-reviewers ,mconley,bolsson

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for Doc failure on BackupUIChild.sys

Backout link: https://hg.mozilla.org/integration/autoland/rev/25105eb1f8e37d76cb3cd1026ecabb27fe85d632
Log link: https://treeherder.mozilla.org/logviewer?job_id=469400288&repo=autoland&lineNumber=777

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4134d4f1c8b7
Show profile backup errors and keep modals open r=backup-reviewers,fluent-reviewers,firefox-desktop-core-reviewers ,mconley,bolsson

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4134d4f1c8b7