Bug 1906108 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Markus 0.5.0 includes a `RegisteredMetricsFilter` ([docs](https://markus.readthedocs.io/en/latest/filters.html#markus.filters.RegisteredMetricsFilter)) which allows us to document all the metrics that Antenna emits with descriptions and types and then enforce only those metrics are emitted during tests. This reduces typos in metrics keys, makes it easier to see our metrics situation, and makes it easier to build dashboards without hunting through code for the name of the thing you forgot.

I prototyped this with Eliot in this pull request:

https://github.com/mozilla-services/eliot/pull/169

I liked the way that felt. The docs are handy:

https://mozilla-eliot.readthedocs.io/en/latest/metrics.html

We should upgrade Markus and write up a metrics yaml file for Antenna.
Markus 5.0.0 includes a `RegisteredMetricsFilter` ([docs](https://markus.readthedocs.io/en/latest/filters.html#markus.filters.RegisteredMetricsFilter)) which allows us to document all the metrics that Antenna emits with descriptions and types and then enforce only those metrics are emitted during tests. This reduces typos in metrics keys, makes it easier to see our metrics situation, and makes it easier to build dashboards without hunting through code for the name of the thing you forgot.

I prototyped this with Eliot in this pull request:

https://github.com/mozilla-services/eliot/pull/169

I liked the way that felt. The docs are handy:

https://mozilla-eliot.readthedocs.io/en/latest/metrics.html

We should upgrade Markus and write up a metrics yaml file for Antenna.

Back to Bug 1906108 Comment 0