Bug 1907571 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The condition to check to see whether the inactive tabs CFR should be shown depends on 2 variables as shown [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#325-328). However, after it is shown, we don't update those variables accordingly. See [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#329-331). We should be updating `lastCfrShownTimeInMillis` in `Settings.kt` ([Searchfox](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt#164)). Add this line to the `onInactiveTabsCFRClick` lambda function in the `TabsTray` call in `TabsTrayFragment`: `requireContext().settings().lastCfrShownTimeInMillis = System.currentTimeMillis()`.
Revision 1 by
on 
The condition to check to see whether the inactive tabs CFR should be shown depends on 2 variables as shown [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#325-328). However, after it is shown, we don't update those variables accordingly. See [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#329-331). We should be updating `lastCfrShownTimeInMillis` in `Settings.kt` ([Searchfox](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt#164)). Add this line to the `onInactiveTabsCFRShown` lambda function in the `TabsTray` call in `TabsTrayFragment`: `requireContext().settings().lastCfrShownTimeInMillis = System.currentTimeMillis()`.
Revision 2 by
on 
The condition to check to see whether the inactive tabs CFR should be shown depends on 2 variables as shown [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#325-328). However, after it is shown, we don't update those variables accordingly. See [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#329-331). We should be updating `lastCfrShownTimeInMillis` in `Settings.kt` ([Searchfox](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt#164)). Add this line to the `onInactiveTabsCFRDismiss` lambda function in the `TabsTray` call in `TabsTrayFragment`: `requireContext().settings().lastCfrShownTimeInMillis = System.currentTimeMillis()`.
Revision 3 by
on 
The condition to check to see whether the inactive tabs CFR should be shown depends on 2 variables as shown [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#325-328). However, after it is shown, we don't update those variables accordingly. See [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#329-331). We should be updating `lastCfrShownTimeInMillis` in `Settings.kt` ([Searchfox](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt#164)). Add this line to the `onInactiveTabsCFRDismiss`, `onInactiveTabsCFRClick`, `onTabAutoCloseBannerViewOptionsClick`, and `onTabAutoCloseBannerDismiss`, lambda functions in the `TabsTray` call in `TabsTrayFragment`: `requireContext().settings().lastCfrShownTimeInMillis = System.currentTimeMillis()`.
Revision 4 by
on 
The condition to check to see whether the inactive tabs CFR should be shown depends on 2 variables as shown [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#325-328). This is similar with the tab auto close banner. However, after it is shown, we don't update those variables accordingly. See [here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt#329-331). We should be updating `lastCfrShownTimeInMillis` in `Settings.kt` ([Searchfox](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt#164)). Add this line to the `onInactiveTabsCFRDismiss`, `onInactiveTabsCFRClick`, `onTabAutoCloseBannerViewOptionsClick`, and `onTabAutoCloseBannerDismiss`, lambda functions in the `TabsTray` call in `TabsTrayFragment`: `requireContext().settings().lastCfrShownTimeInMillis = System.currentTimeMillis()`.

Back to Bug 1907571 Comment 0