Closed Bug 1907571 Opened 4 months ago Closed 3 months ago

After the inactive tabs CFR and tab auto close banner is shown, the appropriate values are not being updated

Categories

(Fenix :: Tabs, defect)

All
Android
defect

Tracking

(firefox130 fixed)

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: npoon, Assigned: npoon)

References

Details

(Whiteboard: [fxdroid][group4])

Attachments

(1 file)

The condition to check to see whether the inactive tabs CFR should be shown depends on 2 variables as shown here. This is similar with the tab auto close banner. However, after it is shown, we don't update those variables accordingly. See here. We should be updating lastCfrShownTimeInMillis in Settings.kt (Searchfox). Add this line to the onInactiveTabsCFRDismiss, onInactiveTabsCFRClick, onTabAutoCloseBannerViewOptionsClick, and onTabAutoCloseBannerDismiss, lambda functions in the TabsTray call in TabsTrayFragment: requireContext().settings().lastCfrShownTimeInMillis = System.currentTimeMillis().

Severity: -- → S3
Whiteboard: [fxdroid][group4]
See Also: → 1907596
See Also: → 1907599
Assignee: nobody → npoon
Status: NEW → ASSIGNED
Summary: After the inactive tabs CFR is shown, the approriate values are not being updated → After the inactive tabs CFR is shown, the appropriate values are not being updated
Summary: After the inactive tabs CFR is shown, the appropriate values are not being updated → After the inactive tabs CFR and inactive tabs auto close banner is shown, the appropriate values are not being updated
Summary: After the inactive tabs CFR and inactive tabs auto close banner is shown, the appropriate values are not being updated → After the inactive tabs CFR and tab auto close banner is shown, the appropriate values are not being updated
Pushed by calu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b272ab0b85de Update `lastCfrShownTimeInMillis` after inactive tabs CFR is dismissed r=android-reviewers,calu
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: