1907571 - After the inactive tabs CFR and tab auto close banner is shown, the appropriate values are not being updated

Status: RESOLVED FIXED

(Fenix :: Tabs, defect)

Description

[Nicholas Poon [:Nick]]

The condition to check to see whether the inactive tabs CFR should be shown depends on 2 variables as shown here. This is similar with the tab auto close banner. However, after it is shown, we don't update those variables accordingly. See here. We should be updating lastCfrShownTimeInMillis in Settings.kt (Searchfox). Add this line to the onInactiveTabsCFRDismiss, onInactiveTabsCFRClick, onTabAutoCloseBannerViewOptionsClick, and onTabAutoCloseBannerDismiss, lambda functions in the TabsTray call in TabsTrayFragment: requireContext().settings().lastCfrShownTimeInMillis = System.currentTimeMillis().

Comment 1

[Nicholas Poon [:Nick]]

Attachment: Bug 1907571 - Update `lastCfrShownTimeInMillis` after inactive tabs CFR is dismissed

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b272ab0b85de
Update `lastCfrShownTimeInMillis` after inactive tabs CFR is dismissed r=android-reviewers,calu

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b272ab0b85de