When Landing an uplift patch to beta , lando throws an error(below) that the patch requires a DOM reviewer. This is not necessary since the central patch already has a DOM reviewer and the beta patch is idenitical (maybe had some conflict resolution) Example bug 1918736 D222159 to central has a DOM reviewer D222304 is requested to beta but wont land with relman approval (Changeset %s alters WebIDL file(s) without DOM peer review:) Raw error output: > Unexpected error while pushing to ssh://hg.mozilla.org/releases/mozilla-beta. > hg error in cmd: hg push -r tip ssh://hg.mozilla.org/releases/mozilla-beta: pushing to ssh://hg.mozilla.org/releases/mozilla-beta > searching for changes > remote: adding changesets > remote: adding manifests > remote: adding file changes > remote: > remote: ******************************* ERROR ******************************* > remote: Changeset 5118788b72ca alters WebIDL file(s) without DOM peer review: > remote: dom/webidl/Navigator.webidl > remote: dom/webidl/PrivateAttribution.webidl > remote: > remote: Please, request review from the #webidl reviewer group or either: > remote: - Andrea Marchesini (:baku) > remote: - Andreas Farre (:farre) > remote: - Andrew McCreight (:mccr8) > remote: - Andrew Sutherland (:asuth) > remote: - Bobby Holley (:bholley) > remote: - Edgar Chen (:edgar) > remote: - Emilio Cobos (:emilio) > remote: - Henri Sivonen (:hsivonen) > remote: - Kagami Rosylight (:saschanaz) > remote: - Nika Layzell (:mystor) > remote: - Olli Pettay (:smaug) > remote: - Peter Van der Beken (:peterv) > remote: - Sean Feng (:sefeng) > remote: ********************************************************************* > remote: > remote: transaction abort! > remote: rollback completed > > remote: pretxnchangegroup.mozhooks hook failed > abort: push failed on remote
Bug 1921016 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
When Landing an uplift patch to beta , lando throws an error(below) that the patch requires a DOM reviewer. This is not necessary since the central patch already has a DOM reviewer and the beta patch is idenitical (maybe had some conflict resolution) Example bug 1918736 [D222159](https://phabricator.services.mozilla.com/D222159) to central has a DOM reviewer [D222304](https://phabricator.services.mozilla.com/D222304) is requested to beta but wont land with relman approval (Changeset %s alters WebIDL file(s) without DOM peer review:) Raw error output: > Unexpected error while pushing to ssh://hg.mozilla.org/releases/mozilla-beta. > hg error in cmd: hg push -r tip ssh://hg.mozilla.org/releases/mozilla-beta: pushing to ssh://hg.mozilla.org/releases/mozilla-beta > searching for changes > remote: adding changesets > remote: adding manifests > remote: adding file changes > remote: > remote: ******************************* ERROR ******************************* > remote: Changeset 5118788b72ca alters WebIDL file(s) without DOM peer review: > remote: dom/webidl/Navigator.webidl > remote: dom/webidl/PrivateAttribution.webidl > remote: > remote: Please, request review from the #webidl reviewer group or either: > remote: - Andrea Marchesini (:baku) > remote: - Andreas Farre (:farre) > remote: - Andrew McCreight (:mccr8) > remote: - Andrew Sutherland (:asuth) > remote: - Bobby Holley (:bholley) > remote: - Edgar Chen (:edgar) > remote: - Emilio Cobos (:emilio) > remote: - Henri Sivonen (:hsivonen) > remote: - Kagami Rosylight (:saschanaz) > remote: - Nika Layzell (:mystor) > remote: - Olli Pettay (:smaug) > remote: - Peter Van der Beken (:peterv) > remote: - Sean Feng (:sefeng) > remote: ********************************************************************* > remote: > remote: transaction abort! > remote: rollback completed > > remote: pretxnchangegroup.mozhooks hook failed > abort: push failed on remote