1921016 - Lando requires DOM reviewers on uplift patches targeting beta

Status: RESOLVED FIXED

(Conduit :: Lando, defect)

Description

[Dianna Smith [:diannaS]]

When Landing an uplift patch to beta , lando throws an error(below) that the patch requires a DOM reviewer. This is not necessary since the central patch already has a DOM reviewer and the beta patch is idenitical (maybe had some conflict resolution)

Example bug 1918736
D222159 to central has a DOM reviewer
D222304 is requested to beta but wont land with relman approval (Changeset %s alters WebIDL file(s) without DOM peer review:)

Raw error output:

Unexpected error while pushing to ssh://hg.mozilla.org/releases/mozilla-beta.
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/releases/mozilla-beta: pushing to ssh://hg.mozilla.org/releases/mozilla-beta
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote:
remote: ******************************* ERROR *******************************
remote: Changeset 5118788b72ca alters WebIDL file(s) without DOM peer review:
remote: dom/webidl/Navigator.webidl
remote: dom/webidl/PrivateAttribution.webidl
remote:
remote: Please, request review from the #webidl reviewer group or either:
remote: - Andrea Marchesini (:baku)
remote: - Andreas Farre (:farre)
remote: - Andrew McCreight (:mccr8)
remote: - Andrew Sutherland (:asuth)
remote: - Bobby Holley (:bholley)
remote: - Edgar Chen (:edgar)
remote: - Emilio Cobos (:emilio)
remote: - Henri Sivonen (:hsivonen)
remote: - Kagami Rosylight (:saschanaz)
remote: - Nika Layzell (:mystor)
remote: - Olli Pettay (:smaug)
remote: - Peter Van der Beken (:peterv)
remote: - Sean Feng (:sefeng)
remote: *********************************************************************
remote:
remote: transaction abort!
remote: rollback completed

remote: pretxnchangegroup.mozhooks hook failed
abort: push failed on remote

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: hooks: disable DOM reviewer hooks on `scm_allow_direct_push` repos (Bug 1921016) r?jcristau

Stop running DOM reviewer hooks on Firefox releasing repos with
scm_allow_direct_push permissions. On these repos, if the user
is able to push despite the scm_allow_direct_push permission,
they have enough knowledge and authority to make the push despite
a missing DOM review on a patch. This is the case for uplift
patches landed via Lando.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/3237431ee92c
hooks: disable DOM reviewer hooks on scm_allow_direct_push repos r=jcristau