Bug 1921810 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Backed out for causing 
* [Backout link](https://hg.mozilla.org/integration/autoland/rev/8b99bc7da58daf71d02e6bb539b1f55fc0261d0d)
* [Push with failures](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=823808ae582a2b5f906c5e7442932fc6fde3fb11&selectedTaskRun=SDxgRZHNTN2J39x2m8cZtw.0) 
* [Failure Log](https://treeherder.mozilla.org/logviewer?job_id=478706862&repo=autoland&lineNumber=85570) 
* Failure line: 
```
[task 2024-10-17T13:23:35.431Z] 13:23:35     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'
[task 2024-10-17T13:23:35.434Z] 13:23:35     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o AntiTrackingUtils.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -fstrict-flex-arrays=1 -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/antitracking -I/builds/worker/workspace/obj-build/toolkit/components/antitracking -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fPIC -fcrash-diagnostics-dir=/builds/worker/artifacts -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/AntiTrackingUtils.o.pp   /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp
[task 2024-10-17T13:23:35.434Z] 13:23:35    ERROR -  /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp:546:24: error: use of undeclared identifier 'ContentBlockingAllowList'
[task 2024-10-17T13:23:35.434Z] 13:23:35     INFO -    546 |     if (httpChannel && ContentBlockingAllowList::Check(httpChannel)) {
[task 2024-10-17T13:23:35.435Z] 13:23:35     INFO -        |                        ^
[task 2024-10-17T13:23:35.435Z] 13:23:35     INFO -  1 error generated.
[task 2024-10-17T13:23:35.435Z] 13:23:35    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:675: AntiTrackingUtils.o] Error 1
[task 2024-10-17T13:23:35.436Z] 13:23:35     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'
```
Revision 1 by
on 
Backed out for causing build bustages in AntiTrackingUtils.cpp.
* [Backout link](https://hg.mozilla.org/integration/autoland/rev/8b99bc7da58daf71d02e6bb539b1f55fc0261d0d)
* [Push with failures](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=823808ae582a2b5f906c5e7442932fc6fde3fb11&selectedTaskRun=SDxgRZHNTN2J39x2m8cZtw.0) 
* [Failure Log](https://treeherder.mozilla.org/logviewer?job_id=478706862&repo=autoland&lineNumber=85570) 
* Failure line: 
```
[task 2024-10-17T13:23:35.431Z] 13:23:35     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'
[task 2024-10-17T13:23:35.434Z] 13:23:35     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o AntiTrackingUtils.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -fstrict-flex-arrays=1 -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/antitracking -I/builds/worker/workspace/obj-build/toolkit/components/antitracking -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fPIC -fcrash-diagnostics-dir=/builds/worker/artifacts -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/AntiTrackingUtils.o.pp   /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp
[task 2024-10-17T13:23:35.434Z] 13:23:35    ERROR -  /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp:546:24: error: use of undeclared identifier 'ContentBlockingAllowList'
[task 2024-10-17T13:23:35.434Z] 13:23:35     INFO -    546 |     if (httpChannel && ContentBlockingAllowList::Check(httpChannel)) {
[task 2024-10-17T13:23:35.435Z] 13:23:35     INFO -        |                        ^
[task 2024-10-17T13:23:35.435Z] 13:23:35     INFO -  1 error generated.
[task 2024-10-17T13:23:35.435Z] 13:23:35    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:675: AntiTrackingUtils.o] Error 1
[task 2024-10-17T13:23:35.436Z] 13:23:35     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'
```

Back to Bug 1921810 Comment 5