1921810 - Third-party cookies is still blocked after ETP toggle is off.

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Tim Huang[:timhuang]]

After we disable ETP protection for a site, the third-party cookie is not accessible. In this case, the foreign context under the site should have third-party cookie access because foreign contexts have storage access.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1921810 - Part 1: Considering the content blocking allowlist when calculating the StoragePermission for a channel. r?bvandersloot!

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1921810 - Part 2: Exposing UsingStorageAccess flag on WindowContext. r?nika!

Depends on D224205

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1921810 - Part 3: Add a test. r?bvandersloot!

Depends on D224206

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7417d8d7fde
Part 1: Considering the content blocking allowlist when calculating the StoragePermission for a channel. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/71de8c527b8b
Part 2: Exposing UsingStorageAccess flag on WindowContext. r=nika
https://hg.mozilla.org/integration/autoland/rev/823808ae582a
Part 3: Add a test. r=bvandersloot,anti-tracking-reviewers

Comment 5

[agoloman]

Backed out for causing build bustages in AntiTrackingUtils.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line:

[task 2024-10-17T13:23:35.431Z] 13:23:35     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'
[task 2024-10-17T13:23:35.434Z] 13:23:35     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o AntiTrackingUtils.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -fstrict-flex-arrays=1 -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/antitracking -I/builds/worker/workspace/obj-build/toolkit/components/antitracking -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fPIC -fcrash-diagnostics-dir=/builds/worker/artifacts -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/AntiTrackingUtils.o.pp   /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp
[task 2024-10-17T13:23:35.434Z] 13:23:35    ERROR -  /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp:546:24: error: use of undeclared identifier 'ContentBlockingAllowList'
[task 2024-10-17T13:23:35.434Z] 13:23:35     INFO -    546 |     if (httpChannel && ContentBlockingAllowList::Check(httpChannel)) {
[task 2024-10-17T13:23:35.435Z] 13:23:35     INFO -        |                        ^
[task 2024-10-17T13:23:35.435Z] 13:23:35     INFO -  1 error generated.
[task 2024-10-17T13:23:35.435Z] 13:23:35    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:675: AntiTrackingUtils.o] Error 1
[task 2024-10-17T13:23:35.436Z] 13:23:35     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e4ec5d43665
Part 1: Considering the content blocking allowlist when calculating the StoragePermission for a channel. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/f5c3da89e372
Part 2: Exposing UsingStorageAccess flag on WindowContext. r=nika
https://hg.mozilla.org/integration/autoland/rev/60fa50da23e9
Part 3: Add a test. r=bvandersloot,anti-tracking-reviewers

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7e4ec5d43665
https://hg.mozilla.org/mozilla-central/rev/f5c3da89e372
https://hg.mozilla.org/mozilla-central/rev/60fa50da23e9

Comment 8

[Ciprian Georgiu, Desktop QA]

I've reproduced this issue with an affected Beta build 133.0b1, under Win 11 x64.

The issue is verified as fixed on RC1 134.0 with Win 11, macOS 14 and Ubuntu 24.04. The Cookie “thirdPartyCookie” has been rejected because it is foreign and does not have the “Partitioned“ attribute. message is not displayed anymore on the https://testing-3pcd.glitch.me/ when the ETP toggle is off, and also, the third party cookies are displayed as unblocked on the page.