Bug 1925037 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Basically takes the Firefox function, adds the callback parameter and fix the callers to pass it differently. We do not currently use the other optional parameters. Should we keep them or take out?

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: usally none but an error is logged.
Testing completed (on m-c, etc.): 2.53.20b1 pre
Risk to taking this patch (and alternatives if risky): tested and working.
String changes made by this patch: --
Revision 1 by
on 
Basically takes the Firefox function, adds the callback parameter and fix the callers to pass it differently. We do not currently use the other optional parameters. Should we keep them or take out?

2 mini drive by fixes as noted in the patch.

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: usally none but an error is logged.
Testing completed (on m-c, etc.): 2.53.20b1 pre
Risk to taking this patch (and alternatives if risky): tested and working.
String changes made by this patch: --

Back to Bug 1925037 Comment 1