1925037 - Align the SeaMonkey switchToTabHavingURI() call syntax with Firefox and toolkit

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank-Rainer Grahl (:frg)]

We use a callback in switchToTabHavingURI() but tookit passes optional parameters for the function and the actual load in this location. You occasionally see a

Timestamp: 16.10.2024, 15:47:53
Error: TypeError: aCallback is not a function
Source File: chrome://communicator/content/utilityOverlay.js
Line: 1793

error because of this in the log. This is usually not fatal because the call is at the end of the fuction call but should not happen.

To test just open the addon manager select the wheel and click Debug Add-ons.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1925037-switchToTabHavingURI-25320.patch

Basically takes the Firefox function, adds the callback parameter and fix the callers to pass it differently. We do not currently use the other optional parameters. Should we keep them or take out?

2 mini drive by fixes as noted in the patch.

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: usally none but an error is logged.
Testing completed (on m-c, etc.): 2.53.20b1 pre
Risk to taking this patch (and alternatives if risky): tested and working.
String changes made by this patch: --

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1925037-switchToTabHavingURI-1_1-25320.patch

Basically takes the Firefox function, adds the callback parameter and fix the callers to pass it differently. We do not currently use the other optional parameters browser uses so per discussion take them out for now.

2 mini drive by fixes as noted in the patch.

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: usually none but an error is logged.
Testing completed (on m-c, etc.): 2.53.20b1 pre
Risk to taking this patch (and alternatives if risky): tested and working.
String changes made by this patch: --

Comment 3

[Ian Neal]

Comment on attachment 9431404 [details] [diff] [review]
1925037-switchToTabHavingURI-1_1-25320.patch

[Triage Comment]
LGTM r/a=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/75a7530cb06f
Pass optional parameters to switchToTabHavingURI as an array. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/40f0571c29839ec189a4c67948c1434b919034ed
Pass optional parameters to switchToTabHavingURI as an array. r=IanN a=IanN