I think that makes sense. Hiding the Location field is reasonable when adding a bookmark through the Star button (or CTRL+D) as the url is already visible in the address bar. I'm not sure why this was configured this way, it somehow happened about 15 years ago. Changing PlacesCommandHook::BookmarkLink to actually show "location" will change the following Add Bookmark UIs: * Bookmark Link in context menu * Add bookmark for html frame * Add bookmark for synced tab from sidebar * Add bookmark for NewTab entries I think showing the location is reasonable in all of these cases as the url is not visible originally. Romain, sorry for nagging again, can anyone Product or UX make a decision here?
Bug 1939280 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I think that makes sense. I'm not sure why this was configured this way, it somehow happened about 15 years ago. Hiding the Location field is reasonable when adding a bookmark through the Star button (or CTRL+D) as the url is already visible in the address bar. Changing PlacesCommandHook::BookmarkLink to actually show "location" will change the following Add Bookmark UIs: * Bookmark Link in context menu * Add bookmark for html frame * Add bookmark for synced tab from sidebar * Add bookmark for NewTab entries I think showing the location is reasonable in all of these cases as the url is not visible originally. Romain, sorry for nagging again, can anyone Product or UX make a decision here?
I think that makes sense. I'm not sure why this was configured this way, it somehow happened about 15 years ago. Hiding the Location field is reasonable when adding a bookmark through the Star button (or CTRL+D) as the url is already visible in the address bar. Changing PlacesCommandHook::BookmarkLink to actually show "location" will change the following Add Bookmark UIs: * Bookmark Link in context menu * Add bookmark for html frame * Add bookmark for synced tab from sidebar * Add bookmark for NewTab entries I think showing the location is reasonable in all of these cases, as the url is not visible anywhere (if not briefly) before. Romain, sorry for nagging again, can anyone Product or UX make a decision here?
I think that makes sense. I'm not sure why this was configured this way, it somehow happened about 15 years ago. Hiding the Location field is reasonable when adding a bookmark through the Star button (or CTRL+D) as the url is already visible in the address bar. Changing PlacesCommandHook::BookmarkLink to actually show "location" will change the following Add Bookmark UIs: * Bookmark Link in context menu * Add bookmark for html frame * Add bookmark for synced tab from sidebar * Add bookmark for NewTab Stories I think showing the location is reasonable in all of these cases, as the url is not visible anywhere (if not briefly) before. Romain, sorry for nagging again, can anyone Product or UX make a decision here?