1939280 - Bookmark Link... dialog should allow editing URL to remove tracking parameters

Status: NEW

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[jscher2000]

Attachment: Comparison of Bookmark Link... and Bookmark Tab... dialogs

When the modal dialog is displayed for Bookmark Tab, users can review and edit the URL field, but that field is hidden when the dialog is displayed for Bookmark Link. Links often contain tracking parameters that users could remove if given the opportunity.

Ref. https://old.reddit.com/r/firefox/comments/1hmjf3n/is_there_a_way_to_editmodify_a_url_being/

Can we unhide the URL field for Bookmark Link?

Integration with link sanitization would also be nice, but I don't want to make this request overly complicated.

Note: It is inconvenient to use userChrome.css rules as a workaround because bookmarkProperties.xhtml is displayed in a fixed-height and clipped window rather than one which expands to display the full height of the dialog content.

Comment 1

[Marco Bonardo [:mak]]

I think that makes sense.
I'm not sure why this was configured this way, it somehow happened about 15 years ago.

Hiding the Location field is reasonable when adding a bookmark through the Star button (or CTRL+D) as the url is already visible in the address bar.

Changing PlacesCommandHook::BookmarkLink to actually show "location" will change the following Add Bookmark UIs:

• Bookmark Link in context menu
• Add bookmark for html frame
• Add bookmark for synced tab from sidebar
• Add bookmark for NewTab Stories

I think showing the location is reasonable in all of these cases, as the url is not visible anywhere (if not briefly) before.

Romain, sorry for nagging again, can anyone Product or UX make a decision here?

Comment 2

[Romain Testard [:RT]]

Vesta, can you please direct to the right PM? (Desktop experience fundamentals)

Comment 3

[Romain Testard [:RT]]

Now with NI to Vesta

Comment 4

[wbob]

users asking for this on Connect - https://connect.mozilla.org/t5/ideas/re-enable-direct-editing-of-url-while-bookmarking/idi-p/85108