Bug 1940816 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
For historical reasons, about:welcome, ASRouter, New Tab have often shared the activity-stream namespace for chrome://  for image assets. 
https://searchfox.org/mozilla-central/search?q=chrome%3A%2F%2Factivity-stream%2F&path=&case=false&regexp=false
e.g.
chrome://activity-stream/content/data/content/assets/glyph-modal-delete-20.svg
chrome://activity-stream/content/data/content/assets/glyph-webextension-16.svg
chrome://activity-stream/content/data/content/assets/mr-settodefault.svg

Scope of this bug is to remove `chrome://activity-stream/` mapping from locally packaged assets outside of newtab folder by updating below jar files 
https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/jar.mn#40
https://searchfox.org/mozilla-central/source/browser/components/asrouter/jar.mn#40
Revision 1 by
on 
For historical reasons, about:welcome, ASRouter, New Tab have often shared the activity-stream namespace for chrome://  for image assets. 
https://searchfox.org/mozilla-central/search?q=chrome%3A%2F%2Factivity-stream%2F&path=&case=false&regexp=false
e.g.
chrome://activity-stream/content/data/content/assets/glyph-modal-delete-20.svg
chrome://activity-stream/content/data/content/assets/glyph-webextension-16.svg
chrome://activity-stream/content/data/content/assets/mr-settodefault.svg

https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/jar.mn#40
https://searchfox.org/mozilla-central/source/browser/components/asrouter/jar.mn#40

To build newtab as an extension, we should decouple this common mapping and update packaged assets inside of newtab folder `  to use `chrome://newtab` and `resource://newtab`
Revision 2 by
on 
For historical reasons, about:welcome, ASRouter, New Tab have often shared the activity-stream namespace for chrome://  for image assets. 
https://searchfox.org/mozilla-central/search?q=chrome%3A%2F%2Factivity-stream%2F&path=&case=false&regexp=false
e.g.
chrome://activity-stream/content/data/content/assets/glyph-modal-delete-20.svg
chrome://activity-stream/content/data/content/assets/glyph-webextension-16.svg
chrome://activity-stream/content/data/content/assets/mr-settodefault.svg

https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/jar.mn#40
https://searchfox.org/mozilla-central/source/browser/components/asrouter/jar.mn#40

To build newtab as an extension, we should decouple this common mapping and update packaged assets inside of newtab folder `  to use `chrome://newtab`  and  `resource://newtab`
Revision 3 by
on 
For historical reasons, about:welcome, ASRouter, New Tab have often shared the activity-stream namespace for chrome://  for image assets. 
https://searchfox.org/mozilla-central/search?q=chrome%3A%2F%2Factivity-stream%2F&path=&case=false&regexp=false
e.g.
chrome://activity-stream/content/data/content/assets/glyph-modal-delete-20.svg
chrome://activity-stream/content/data/content/assets/glyph-webextension-16.svg
chrome://activity-stream/content/data/content/assets/mr-settodefault.svg

https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/jar.mn#40
https://searchfox.org/mozilla-central/source/browser/components/asrouter/jar.mn#40

To build newtab as an extension, we should decouple this common mapping and update packaged assets inside of newtab folder  to use  `chrome://newtab`  and  `resource://newtab`

Back to Bug 1940816 Comment 0