1940816 - Put newtab chrome and resource assets under chrome://newtab and resource://newtab

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Punam Dahiya [:pdahiya]]

For historical reasons, about:welcome, ASRouter, New Tab have often shared the activity-stream namespace for chrome:// for image assets.
https://searchfox.org/mozilla-central/search?q=chrome%3A%2F%2Factivity-stream%2F&path=&case=false&regexp=false
e.g.
chrome://activity-stream/content/data/content/assets/glyph-modal-delete-20.svg
chrome://activity-stream/content/data/content/assets/glyph-webextension-16.svg
chrome://activity-stream/content/data/content/assets/mr-settodefault.svg

https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/jar.mn#40
https://searchfox.org/mozilla-central/source/browser/components/asrouter/jar.mn#40

To build newtab as an extension, we should decouple this common mapping and update packaged assets inside of newtab folder to use chrome://newtab and resource://newtab

Comment 1

[Punam Dahiya [:pdahiya]]

Noticed in newtab as an extension early prototype chrome://activity-stream url mapping is impacting both newtab and outside newtab image assets. Clarifying if this fix should be blocking https://mozilla-hub.atlassian.net/browse/HNT-297 .

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1940816 - Put newtab chrome and resource assets under chrome://newtab and resource://newtab

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5785f202084e
Put newtab chrome and resource assets under chrome://newtab and resource://newtab r=home-newtab-reviewers,omc-reviewers,mconley,credential-management-reviewers,marco,emcminn,valentin,dimi

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing Bpgo bustage

Backout link

Push with failures

Failure log

Edit: Relanded since the failure seems to be caused by something else.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/321052fb2ab5
Put newtab chrome and resource assets under chrome://newtab and resource://newtab r=home-newtab-reviewers,omc-reviewers,mconley,credential-management-reviewers,marco,emcminn,valentin,dimi CLOSED TREE

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/321052fb2ab5