Bugzilla

Let me give a quick update on this. I'm currently working on disabling the feature _entirely_ for now (Bug 1959492). Across all update channels.

I have a few other small things on my plate before I can get back to this, but then I guess I will try option (a) from Comment 36

(In reply to Robin Steuber (she/her) [:bytesized] from comment #36)
> I think that the solutions here are either (a) delete the lock file when the "Restart" button is clicked, or (b) let go of the lock itself earlier in shutdown. I'm leaning towards option (b).

I sure hope that fixes it, because if it doesn't I'm gonna be really stumped as to what's causing this problem.

I'll try to get a patch up next week, then I am hoping that I can get some of the people here to test it. Then if timing allows, I want to uplift it to beta. Otherwise, we can just wait for it to ride the train to beta. And then I want to try to get some people here to test it on beta, where it seems to reproduce more consistently.

If the above _does not_ work (and we still don't know why), we basically are left with two choices:
 1. Revert this feature's functionality to the old functionality (pre-Bug 1907124), or
 2. Spend a few days making a custom build with tons and tons of extra logging, hope that someone that can reproduce this will be interested in running it and giving us the logs, and then hope that those logs point us in the direction of the actual fix without _more_ custom builds with _more_ logging.
We have not yet decided which of those we would prefer to pursue in that case.

I'm sorry this has been such a nightmare, y'all. I really thought we had it fixed before I went on vacation, and... it's a long story.

Let me give a quick update on this. I'm currently working on disabling the feature _entirely_ for now (Bug 1959492). Across all update channels.

I have a few other small things on my plate before I can get back to this, but then I guess I will try option (a) from Comment 36.

(In reply to Robin Steuber (she/her) [:bytesized] from comment #36)
> I think that the solutions here are either (a) delete the lock file when the "Restart" button is clicked, or (b) let go of the lock itself earlier in shutdown. I'm leaning towards option (b).

I sure hope that fixes it, because if it doesn't I'm gonna be really stumped as to what's causing this problem.

I'll try to get a patch up next week, then I am hoping that I can get some of the people here to test it. Then if timing allows, I want to uplift it to beta. Otherwise, we can just wait for it to ride the train to beta. And then I want to try to get some people here to test it on beta, where it seems to reproduce more consistently.

If the above _does not_ work (and we still don't know why), we basically are left with two choices:
 1. Revert this feature's functionality to the old functionality (pre-Bug 1907124), or
 2. Spend a few days making a custom build with tons and tons of extra logging, hope that someone that can reproduce this will be interested in running it and giving us the logs, and then hope that those logs point us in the direction of the actual fix without _more_ custom builds with _more_ logging.

We have not yet decided which of those we would prefer to pursue in that case.

I'm sorry this has been such a nightmare, y'all. I really thought we had it fixed before I went on vacation, and... it's a long story.

Let me give a quick update on this. I'm currently working on disabling the feature _entirely_ for now (Bug 1959492). Across all update channels.

I have a few other small things on my plate before I can get back to this, but then I guess I will try option (a) from Comment 36.

(In reply to Robin Steuber (she/her) [:bytesized] from comment #36)
> I think that the solutions here are either (a) delete the lock file when the "Restart" button is clicked, or (b) let go of the lock itself earlier in shutdown. I'm leaning towards option (b).

I sure hope that fixes it, because if it doesn't I'm gonna be really stumped as to what's causing this problem.

I'll try to get a patch up next week, then I am hoping that I can get some of the people here to test it. Then if timing allows, I want to uplift it to beta. Otherwise, we can just wait for it to ride the train to beta. And then I want to try to get some people here to test it on beta, where it seems to reproduce more consistently.

If the above _does not_ work (and we still don't know why), we basically are left with two choices:
 1. Revert this feature's functionality to the old functionality (pre-Bug 1907124), or
 2. Spend a few days making a custom build with tons and tons of extra logging, hope that someone that can reproduce this will be interested in running it and giving us the logs, and then hope that those logs point us in the direction of the actual fix without _more_ custom builds with _more_ logging.

We have not yet decided which of those we would prefer to pursue in that case.

I'm sorry this has been such a nightmare, y'all. I really thought we had it fixed before I went on vacation, and... it's a long story. Obviously we dropped the ball.

Let me give a quick update on this. I'm currently working on disabling the feature _entirely_ for now (Bug 1959492). Across all update channels.

I have a few other small things on my plate before I can get back to this, but then I guess I will try option (a) from Comment 36.

(In reply to Robin Steuber (she/her) [:bytesized] from comment #36)
> I think that the solutions here are either (a) delete the lock file when the "Restart" button is clicked, or (b) let go of the lock itself earlier in shutdown. I'm leaning towards option (b).

I sure hope that fixes it, because if it doesn't I'm gonna be really stumped as to what's causing this problem.

I'll try to get a patch up next week, then I am hoping that I can get some of the people here to test it. Then if timing allows, I want to uplift it to beta. Otherwise, we can just wait for it to ride the train to beta. And then I want to try to get some people here to test it on beta, where it seems to reproduce more consistently.

If the above _does not_ work (and we still don't know why), we basically are left with two choices:
 1. Revert this feature's functionality to the old functionality (pre-Bug 1907124), or
 2. Spend a few days making a custom build with tons and tons of extra logging, hope that someone that can reproduce this will be interested in running it and giving us the logs, and then hope that those logs point us in the direction of the actual fix without _more_ custom builds with _more_ logging.

We have not yet decided which of those we would prefer to pursue in that case.

I'm sorry this has been such a nightmare, y'all. I really thought we had it fixed before I went on vacation, and... it's a long story. Obviously we dropped the ball, since this made it to Release.