1907124 - [Meta] Bypassing Updates with Multiple Profiles

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement, P3)

Comment 1

[Robin Steuber (she/her) [:bytesized]]

There was a bit of a discussion today about how notifications should be displayed with this feature. The main questions was "Should 'Restart to Update' buttons force a restart and, if not, how do we avoid showing the notification when a restart will not result in an update?"

The answer that we have landed on is that we will sidestep this problem by always having the defaults for the update timeout pref and the notification timeout pref be the same value. We'll document in the comments for the pref definitions that these values differing can result in unexpected behavior.

Comment 2

[Robin Steuber (she/her) [:bytesized]]

Just for convenient reference:

This landed in two stacks.

2024-10-15, version 133
Bug 1922395
https://hg.mozilla.org/mozilla-central/rev/14a04ceafba4 (Refactor BITS request creation into its own function)
https://hg.mozilla.org/mozilla-central/rev/c10e23cb1377 (Turn Post Update Processing into initialization function)
https://hg.mozilla.org/mozilla-central/rev/abf0928161d6 (Always try to cancel any associated BITS job before cleaning up a downloading update)
https://hg.mozilla.org/mozilla-central/rev/170b465d0f64 (Add tests to verify update init fixes)
https://hg.mozilla.org/mozilla-central/rev/3332e79d10cd (Correctly identify downloading active update)
https://hg.mozilla.org/mozilla-central/rev/ef1edab6a75b (Fix tests broken by preserving pending updates at startup)

2024-12-13, version 135
Bug 1907127
https://hg.mozilla.org/mozilla-central/rev/608d68ca5b0e (Adds usingDefaultInstallDate to Update objects)
https://hg.mozilla.org/mozilla-central/rev/8f6065837da3 (Add support for writing update.timestamp)
https://hg.mozilla.org/mozilla-central/rev/118a3fe99c1e (Read update.timestamp at startup and use it to delay updates)
Bug 1907120
https://hg.mozilla.org/mozilla-central/rev/2a19a01424f1 (Remove other multi-instance checks now that we check at startup)
Bug 1907128
https://hg.mozilla.org/mozilla-central/rev/811fa9d7c8a6 (Add telemetry to monitor reasons why we don't apply updates at startup)
Bug 1907126
https://hg.mozilla.org/mozilla-central/rev/b5f433a476de (Refactor out repeated update testing code)
https://hg.mozilla.org/mozilla-central/rev/2c26ce3f8dd3 (Split --test-process-updates functionality)
https://hg.mozilla.org/mozilla-central/rev/0743d5998d6a (Add testing for the multi session install lock feature)
https://hg.mozilla.org/mozilla-central/rev/a4acaa6581bb (Make common test functionality more self contained)