We've got this about:config pref defined, defaulting to `false`: https://searchfox.org/mozilla-central/rev/3076c9156ef84aae253ffdc1d391e0bfab2c406b/modules/libpref/init/StaticPrefList.yaml#15278-15281 ``` - name: privacy.fingerprintingProtection.pbmode type: RelaxedAtomicBool value: false mirror: always ``` However, it really defaults to `true` everywhere because we give it a different value in various product-specific .js files: https://searchfox.org/mozilla-central/rev/3076c9156ef84aae253ffdc1d391e0bfab2c406b/browser/app/profile/firefox.js#2471 ```js pref("privacy.fingerprintingProtection.pbmode", true); ``` (This^ was originally Nightly-only but it became unconditional as of bug 1849903.) We've also got it defined for Android here: https://searchfox.org/mozilla-central/rev/3076c9156ef84aae253ffdc1d391e0bfab2c406b/mobile/android/app/geckoview-prefs.js#394 ```js pref("privacy.fingerprintingProtection.pbmode", true); ``` Maybe we should remove those two `pref(...)` lines, and just set the default by doing `s/false/true/` in `StaticPrefList.yaml`, to reduce confusion and duplicated mentions of the pref? (This would of course mean a change in defaults for other Mozilla-based products like Thunderbird, but I'm not sure Thunderbird has a private browsing mode equivalent anyway, so I'm not sure it matters for them, and to the extent that it does matter, it might be an improvement...) timhuang, do you know if there's any reason we're using firefox.js to set the default here at this point?
Bug 1942947 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
We've got this about:config pref defined, defaulting to `false`: https://searchfox.org/mozilla-central/rev/3076c9156ef84aae253ffdc1d391e0bfab2c406b/modules/libpref/init/StaticPrefList.yaml#15278-15281 ``` - name: privacy.fingerprintingProtection.pbmode type: RelaxedAtomicBool value: false mirror: always ``` However, it really defaults to `true` everywhere because we give it a different value in various product-specific .js files: https://searchfox.org/mozilla-central/rev/3076c9156ef84aae253ffdc1d391e0bfab2c406b/browser/app/profile/firefox.js#2471 ```js pref("privacy.fingerprintingProtection.pbmode", true); ``` (This^ was originally Nightly-only but it became unconditional as of bug 1849903.) We've also got it defined for Android here: https://searchfox.org/mozilla-central/rev/3076c9156ef84aae253ffdc1d391e0bfab2c406b/mobile/android/app/geckoview-prefs.js#394 ```js pref("privacy.fingerprintingProtection.pbmode", true); ``` Maybe we should remove those two `pref(...)` lines, and just set the default by doing `s/false/true/` in `StaticPrefList.yaml`, to reduce confusion and duplicated mentions of the pref? (This would of course mean a change in defaults for other Mozilla-based products like Thunderbird, but I'm not sure Thunderbird has a private browsing mode equivalent anyway, so I'm not sure it matters for them, and to the extent that it does matter, it might be an improvement...) timhuang, do you know if there's any reason we're using these JS files rather than `StaticPrefList.yaml` to set the default here at this point?