Bug 1943473 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This is part of some Suggest refactoring/cleanup I'd like to do.

Suggest results should always have `payload.isSponsored` set appropriately. Right now it's kind of haphazard: some do, some don't, and some that should don't.

I don't think it actually matters too much, though. The only place that checks `isSponsored` for Suggest results is [here](https://searchfox.org/mozilla-central/rev/55706b888f91fffa6f045f7cbc1a7b1c34598292/browser/components/urlbar/UrlbarInput.sys.mjs#1082) in `UrlbarInput.pickResult()` when it sets `triggeringSponsoredURL`. AFAIK we're not making much use of sponsored URL history right now, maybe I'm wrong. And of the Suggest results that should set `isSponsored: true` but don't, the only kind that's enabled by default for all Suggest users is Yelp.

Still, for good code hygiene we should make sure it's set properly.
This is part of some Suggest refactoring/cleanup I'd like to do.

Suggest results should always have `payload.isSponsored` set appropriately. Right now it's kind of haphazard: some do, some don't, and some that should have it set to true don't.

I don't think it actually matters too much, though. The only place that checks `isSponsored` for Suggest results is [here](https://searchfox.org/mozilla-central/rev/55706b888f91fffa6f045f7cbc1a7b1c34598292/browser/components/urlbar/UrlbarInput.sys.mjs#1082) in `UrlbarInput.pickResult()` when it sets `triggeringSponsoredURL`. AFAIK we're not making much use of sponsored URL history right now, maybe I'm wrong. And of the Suggest results that should set `isSponsored: true` but don't, the only kind that's enabled by default for all Suggest users is Yelp.

Still, for good code hygiene we should make sure it's set properly.

Back to Bug 1943473 Comment 0