1943473 - Always set isSponsored on Suggest results

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

This is part of some Suggest refactoring/cleanup I'd like to do.

Suggest results should always have payload.isSponsored set appropriately. Right now it's kind of haphazard: some do, some don't, and some that should have it set to true don't.

I don't think it actually matters too much, though. The only place that checks isSponsored for Suggest results is here in UrlbarInput.pickResult() when it sets triggeringSponsoredURL. AFAIK we're not making much use of sponsored URL history right now, maybe I'm wrong. And of the Suggest results that should set isSponsored: true but don't, the only kind that's enabled by default for all Suggest users is Yelp.

Still, for good code hygiene we should make sure it's set properly.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1943473 - Always set isSponsored on Suggest results and refactor "can add suggestion?" logic.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5faed049a259
Always set isSponsored on Suggest results and refactor "can add suggestion?" logic. r=daisuke

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5faed049a259