Bug 1947159 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

When I open the link in the OP's STR, the error message states:

```
Uncaught DOMException: GPUQueue.copyExternalImageToTexture: Cannot get origin from source
```

…which corresponds to [`dom/webgpu/Queue.cpp`:421](https://searchfox.org/mozilla-central/rev/53acdf9ea724c7fc85cfc259e0acf7663f4d34b8/dom/webgpu/Queue.cpp#421) in current Firefox code:

```cpp
if (!aSource.mOrigin.IsGPUOrigin2DDict()) {
    aRv.ThrowInvalidStateError("Cannot get origin from source");
    return;
  }
```

This is happening because the application is providing a sequence (i.e., `[0, 0]`) instead of a dictionary. It's obvious from the code that the method is designed to handle sequences properly (minus validation for the length of the sequence), but we have this incorrect guard clause that bails early when we provide a sequence. Oops!

I've filed a patch to fix the above problem, and that appears to fix the STR for me locally. So, I think the dependency link I set against bug 1921454 is inaccurate.
When I open the link in the OP's STR, the error message states:

```
Uncaught DOMException: GPUQueue.copyExternalImageToTexture: Cannot get origin from source
```

…which corresponds to [`dom/webgpu/Queue.cpp`:421](https://searchfox.org/mozilla-central/rev/53acdf9ea724c7fc85cfc259e0acf7663f4d34b8/dom/webgpu/Queue.cpp#421) in current Firefox code:

```cpp
  if (!aSource.mOrigin.IsGPUOrigin2DDict()) {
    aRv.ThrowInvalidStateError("Cannot get origin from source");
    return;
  }
```

This is happening because the application is providing a sequence (i.e., `[0, 0]`) instead of a dictionary. It's obvious from the code that the method is designed to handle sequences properly (minus validation for the length of the sequence), but we have this incorrect guard clause that bails early when we provide a sequence. Oops!

I've filed a patch to fix the above problem, and that appears to fix the STR for me locally. So, I think the dependency link I set against bug 1921454 is inaccurate.
When I open the link in the OP's STR, the error message states:

```
Uncaught DOMException: GPUQueue.copyExternalImageToTexture: Cannot get origin from source
```

…which corresponds to [`dom/webgpu/Queue.cpp`:420-423](https://searchfox.org/mozilla-central/rev/53acdf9ea724c7fc85cfc259e0acf7663f4d34b8/dom/webgpu/Queue.cpp#420-423) in current Firefox code:

```cpp
  if (!aSource.mOrigin.IsGPUOrigin2DDict()) {
    aRv.ThrowInvalidStateError("Cannot get origin from source");
    return;
  }
```

This is happening because the application is providing a sequence (i.e., `[0, 0]`) instead of a dictionary. It's obvious from the code that the method is designed to handle sequences properly (minus validation for the length of the sequence), but we have this incorrect guard clause that bails early when we provide a sequence. Oops!

I've filed a patch to fix the above problem, and that appears to fix the STR for me locally. So, I think the dependency link I set against bug 1921454 is inaccurate.

Back to Bug 1947159 Comment 4