1947159 - majority of our WebGPU examples error with: GPUQueue.copyExternalImageToTexture: Cannot get origin from source

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[valigursky]

Steps to reproduce:

Load this example: https://playcanvas.vercel.app/#/graphics/model-textured-box
but majority of other examples there behave the same

and in top right corner switch it to use WebGPU

Actual results:

error in the javascript console:

Errors: GPUQueue.copyExternalImageToTexture: Cannot get origin from source

Expected results:

The texture should load and a spinning textured cube should rendered, similarly to WebGL mode.

Both Chrome and Safari can run all examples without any problem.

Example that do not use textures seems to work in WebGPU mode, for example:
https://playcanvas.vercel.app/#/misc/hello-world

Comment 1

[Mayank Bansal]

Probably a dupe of bug 1938709.

Comment 2

[valigursky]

Just pinging this hoping to have this fixed soon. I've noticed Firefox 141 might ship WebGPU on Windows, but pretty much none of our examples work as they all depend on this functionality to load textures.

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1947159 - fix(webgpu): allow sequences for `GPUOrigin2D` r=#webgpu-reviewers!

As this is only used in the source.origin field for
GPUQueue.copyExternalImageToTexture, we can keep this validation in
the body of this method, for now.

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

When I open the link in the OP's STR, the error message states:

Uncaught DOMException: GPUQueue.copyExternalImageToTexture: Cannot get origin from source

…which corresponds to dom/webgpu/Queue.cpp:420-423 in current Firefox code:

  if (!aSource.mOrigin.IsGPUOrigin2DDict()) {
    aRv.ThrowInvalidStateError("Cannot get origin from source");
    return;
  }

This is happening because the application is providing a sequence (i.e., [0, 0]) instead of a dictionary. It's obvious from the code that the method is designed to handle sequences properly (minus validation for the length of the sequence), but we have this incorrect guard clause that bails early when we provide a sequence. Oops!

I've filed a patch to fix the above problem, and that appears to fix the STR for me locally. So, I think the dependency link I set against bug 1921454 is inaccurate.

Comment 5

[Jim Blandy :jimb]

Is this a candidate for beta uplift? We have at least one user saying they're impacted.

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

I was actually wondering that. I don't see why not; it's a pretty low-risk patch, IMO!

I'll plan on asking for uplift unless somebody objects. 🙂

Comment 7

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1947159 - fix(webgpu): allow sequences for `GPUOrigin2D` r=#webgpu-reviewers!

As this is only used in the source.origin field for
GPUQueue.copyExternalImageToTexture, we can keep this validation in
the body of this method, for now.

Original Revision: https://phabricator.services.mozilla.com/D255663

Comment 8

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1947159 - test(webgpu): accept observed intermittent r=#webgpu-reviewers!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7f1595bfeba
https://hg.mozilla.org/integration/autoland/rev/878cac373aa8
fix(webgpu): allow sequences for `GPUOrigin2D` r=webgpu-reviewers,teoxoy

Comment 10

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/878cac373aa8

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: WebGPU will not have an impactful but low-risk fix that allows certain applications to run
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: We change validation in a way that it no longer incorrectly blocks certain cases that merge early with existing well-tested paths that have automated test coverage.
• String changes made/needed: None
• Is Android affected?: no

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d1faa9de2fdf
https://hg.mozilla.org/integration/autoland/rev/163a23c3ec9b
test(webgpu): accept observed intermittent r=webgpu-reviewers,nical

Comment 14

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/163a23c3ec9b

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9610b3ecf73b
https://hg.mozilla.org/releases/mozilla-beta/rev/ff98446c3e6d