Bug 1959800 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
A suggestion from this patch (https://phabricator.services.mozilla.com/D244834?id=1014250) was that onPipModeChanged(True) or onPipModeChanged(False) is not clear whether pip mode is on or off. Rename all occurrences in mobile/ to onPipModeEnabled. One then can use the API without having to consult with documentation to make sure True means "pip enabled".

GeckoView: onPipModeChanged
Android Component: onPictureInPictureModeChanged
Revision 1 by
on 
A suggestion from this patch (https://phabricator.services.mozilla.com/D244834?id=1014250) was that onPipModeChanged(True) or onPipModeChanged(False) is not clear whether pip mode is on or off. Rename all Fenix occurrences in mobile/ from onPictureInPictureModeChanged to onPictureInPictureModeEnabled. One then can use the API without having to consult with documentation to make sure True means "pip enabled".

Back to Bug 1959800 Comment 0