Open Bug 1959800 Opened 8 months ago Updated 8 months ago

Rename onPictureInPictureModeChanged to onPictureInPictureModeEnabled

Categories

(Firefox for Android :: Accounts and Sync, task)

Product:
Firefox for Android
Component:
Accounts and Sync
Platform:
All
Android
Type:
task

Tracking

()

People

(Reporter: calu, Unassigned, Mentored)

Details

(Keywords: good-first-bug)

A suggestion from this patch (https://phabricator.services.mozilla.com/D244834?id=1014250) was that onPipModeChanged(True) or onPipModeChanged(False) is not clear whether pip mode is on or off. Rename all Fenix occurrences in mobile/ from onPictureInPictureModeChanged to onPictureInPictureModeEnabled. One then can use the API without having to consult with documentation to make sure True means "pip enabled".

Mentor: calu
Keywords: good-first-bug
You need to log in before you can comment on or make changes to this bug.