Bugzilla

it turned out to be more tricky that it looked :)

work here can be split into 3 parts: 
1. locking tabs tray fragment; when it's displayed on top of home/tag, those are in onPause so lock won't work from them. Tabs tray lock is more nuanced, because it can lock from normal mode if the tabs tray has a private page opened
2. changing navigation in unlock fragment; if user navigates back through the negative button, we should just close the lock and show the tabstray normal page, not navigating home. So if the user had a regular tab opened, we don't navigate to home page

it turned out to be more tricky that it looked :)

work here can be split into 3 parts: 
1. locking tabs tray fragment; when it's displayed on top of home/tag, those are in onPause so lock won't work from them. Tabs tray lock is more nuanced, because it can lock from normal mode if the tabs tray has a private page opened
2. changing navigation in unlock fragment; if user navigates back through the negative button, we should just close the lock and show the tabstray normal page, not navigating home. So if the user had a regular tab opened, we don't navigate to home page
3. changing colors in the unlock fragment. Current implementation is theme dependent, it assumes that we are in the private theme when we are displaying the fragment. With the introduction of a tabs lock from the normal page, we still might be in normal mode, but browsing private tabs in the tabs tray; hence the private theme colors should be used directly, to always appear the same without theme dependence.

it turned out to be more tricky that it looked :)

work here can be split into 3 parts: 
1. locking tabs tray fragment; when it's displayed on top of home/tag, those are in onPause so lock won't work from them. Tabs tray lock is more nuanced, because it can lock from normal mode if the tabs tray has a private page opened
2. changing navigation in unlock fragment; if user navigates back through the negative button, we should just close the lock and show the tabstray normal page, not navigating home. So if the user had a regular tab opened, we don't navigate to home page
3. changing colors in the unlock fragment. Current implementation is theme dependent, it assumes that we are in the private theme when we are displaying the fragment. With the introduction of a tabs lock from the normal page, we still might be in normal mode, but browsing private tabs in the tabs tray; hence the private theme colors should be used directly, to always appear the same without theme dependence.

need more time with it