1970719 - If user switches to PBM from the tabs tray and minimizes the app and reopens it, the app should be locked and require authenticating

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, defect, P1)

Description

[:Gela]

Attachment: screen-20250605-111130.mp4

Preconditions:

• Have a device lock setup
• enable "Lock private tabs" from private browsing setting

If user switches to PBM from the tabs tray and minimizes the app and reopens it, the app should be locked and require authenticating. Currently whoever opens the app next can see the thumbnails without authenticating.

Not a blocker for 140.

Comment 1

[Vasilica Tamas (Android QA) [:vtamas]]

This issue also applies for locking and unlocking the device while private tabs tray is in focus.

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 1970719 - Part 1: Lock tabs tray when PBM feature is on

Comment 3

[Mike a [:mavduevskiy]]

it turned out to be more tricky that it looked :)

work here can be split into 3 parts:

1. locking tabs tray fragment; when it's displayed on top of home/tag, those are in onPause so lock won't work from them. Tabs tray lock is more nuanced, because it can lock from normal mode if the tabs tray has a private page opened
2. changing navigation in unlock fragment; if user navigates back through the negative button, we should just close the lock and show the tabstray normal page, not navigating home. So if the user had a regular tab opened, we don't navigate to home page
3. changing colors in the unlock fragment. Current implementation is theme dependent, it assumes that we are in the private theme when we are displaying the fragment. With the introduction of a tabs lock from the normal page, we still might be in normal mode, but browsing private tabs in the tabs tray; hence the private theme colors should be used directly, to always appear the same without theme dependence.

need more time with it

Comment 4

[Mike a [:mavduevskiy]]

Attachment: Bug 1970719 - Part 2: Request prompt in UnlockPrivateTabsFragment after onResume

Requesting the biometrics prompt from tabs tray fragment made it possible to have two instances of BiometricPromtpFeature at the same time. The user might trigger prompt by navigating from normal tab page to locked private tab page, and then minimize the app. After they open the app, UnlockFragment will create the second instance of the prompt feature.

The problem is, BiometricPrompt is tied to a fragment's lifecycle, so for to instances to work correctly, the second should start only when the previous has stopped, otherwise the prompt will be still tied to the first fragment. Delaying prompting until the second fragment is in resumed state solves the issue.

Comment 5

[Mike a [:mavduevskiy]]

Attachment: Bug 1970719 - Part 3: Branch out back navigation of UnlockPrivateTabsFragment

Depending on the sorce, the fragment will adjust the navigation flow after success or canceling of authentication process. The old flow for a tab and home page isn't changed, but in case of navigation to the lock fragment from tabs tray, on success it will open the tabs tray private page and on negative button click, it will just close the fragment and show regular tabs.

Comment 6

[Mike a [:mavduevskiy]]

Attachment: Bug 1970719 - Part 4: Adjust UnlockPrivateTabsScreen colors

The parent fragment might also be called within the normal mode, e.g. when the tabs tray is opened on private page, and we want to hide that content. In that case, we can't rely on the default colours, as the theme is still normal, and have to access private theme colours directly.

Comment 7

[Mike a [:mavduevskiy]]

Attachment: Bug 1970719 - Part 5: Refactor previews

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aa4cadf9aaaa
https://hg.mozilla.org/integration/autoland/rev/7753ffb4d66c
Part 1: Lock tabs tray when PBM feature is on r=android-reviewers,twhite
https://github.com/mozilla-firefox/firefox/commit/c545ac6c76c5
https://hg.mozilla.org/integration/autoland/rev/76eeca4ffca4
Part 2: Request prompt in UnlockPrivateTabsFragment after onResume r=android-reviewers,twhite
https://github.com/mozilla-firefox/firefox/commit/363d9be788bd
https://hg.mozilla.org/integration/autoland/rev/d451ebf711b7
Part 3: Branch out back navigation of UnlockPrivateTabsFragment r=android-reviewers,twhite
https://github.com/mozilla-firefox/firefox/commit/589fcb600986
https://hg.mozilla.org/integration/autoland/rev/c6af1fdcaa5d
Part 4: Adjust UnlockPrivateTabsScreen colors r=android-reviewers,twhite
https://github.com/mozilla-firefox/firefox/commit/12f762fd659c
https://hg.mozilla.org/integration/autoland/rev/3a868822984e
Part 5: Refactor previews r=android-reviewers,twhite

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7753ffb4d66c
https://hg.mozilla.org/mozilla-central/rev/76eeca4ffca4
https://hg.mozilla.org/mozilla-central/rev/d451ebf711b7
https://hg.mozilla.org/mozilla-central/rev/c6af1fdcaa5d
https://hg.mozilla.org/mozilla-central/rev/3a868822984e