Bug 1971321 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Needing to fix these issues:

1. Height issues on medium cards caused by bug 1970206, which if you have a row of 4 cards and ads, the images are not all the same height.
2. Some card margin changes
3. Some more refined card image size changes
4. If the hidedescriptions pref is turned on, it also hides descriptions in large cards, which we don't want.
5. Thumbs in large cards is no longer positioned properly because of image size changes
6. Small card meta is being weird in some cases, looks like medium card specificity
7. There is some extra margin above the large card meta
To test:

1. Set "browser.newtabpage.activity-stream.discoverystream.sections.enabled" to `true`
2. Set "browser.newtabpage.activity-stream.discoverystream.refinedCardsLayout.enabled" to `true`

Expected: Should look like the attached screenshot.
Expected: Regression testing too, cards without these prefs, and various combinations, should also look not broken.

Needing to fix these issues:

1. Height issues on medium cards caused by bug 1970206, which if you have a row of 4 cards and ads, the images are not all the same height.
2. Some card margin changes
3. Some more refined card image size changes
4. If the hidedescriptions pref is turned on, it also hides descriptions in large cards, which we don't want.
5. Thumbs in large cards is no longer positioned properly because of image size changes
6. Small card meta is being weird in some cases, looks like medium card specificity
7. There is some extra margin above the large card meta

Back to Bug 1971321 Comment 0