1971321 - Newtab sections refined cards fixes

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

To test:

1. Set "browser.newtabpage.activity-stream.discoverystream.sections.enabled" to true
2. Set "browser.newtabpage.activity-stream.discoverystream.refinedCardsLayout.enabled" to true

Expected: Should look like the attached screenshot.
Expected: Regression testing too, cards without these prefs, and various combinations, should also look not broken.

Needing to fix these issues:

1. Height issues on medium cards caused by bug 1970206, which if you have a row of 4 cards and ads, the images are not all the same height.
2. Some card margin changes
3. Some more refined card image size changes
4. If the hidedescriptions pref is turned on, it also hides descriptions in large cards, which we don't want.
5. Thumbs in large cards is no longer positioned properly because of image size changes
6. Small card meta is being weird in some cases, looks like medium card specificity
7. There is some extra margin above the large card meta

Comment 1

[Scott [:thecount] Downe]

Attachment: image(56).png

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1971321 - Newtab sections refined cards updates

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/19cb83fbf24e
https://hg.mozilla.org/integration/autoland/rev/afbb4b2c425a
Newtab sections refined cards updates r=home-newtab-reviewers,nbarrett

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/afbb4b2c425a

Comment 5

[Scott [:thecount] Downe]

Attachment: Bug 1971321 - Newtab sections refined cards updates

Original Revision: https://phabricator.services.mozilla.com/D253186

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Delay to sections experiment
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps to test in bugzilla
• Risk associated with taking this patch: Low
• Explanation of risk level: Css only to a preffed off feature
• String changes made/needed: None
• Is Android affected?: no

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/64a992e0932f
https://hg.mozilla.org/releases/mozilla-beta/rev/7776d6bd5ff0

Comment 9

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using Firefox Nightly 141.0a1, build id: 20250618211250, Firefox Nightly 142.0a1, build id: 20250625215831 and Firefox RC 140, build id: 20250616215311 and I can confirm that the images from the cards have the following sizes:

• Big cards: 190x 250
• Default cards: 300 x 160
• Small cards: 110 x 117

Marking this enhancement as Verified Fixed.