Bug 1988635 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
To disable theming in forced-colors mode, we will remove the theme colors from the list of colors generated by the LightweightThemeManager.

Based on the early WIP by :emilio (https://phabricator.services.mozilla.com/D260879), it looks like the spot to check for forced-colors mode and conditionally not insert theme colors will be LightweightThemeManager._setProperties, here: https://searchfox.org/firefox-main/source/toolkit/modules/LightweightThemeConsumer.sys.mjs#693

Suggested reviewers: emilio and rpl blocking, morgan non-blocking.
Revision 1 by
on 
To disable theming in forced-colors mode, we will remove the theme colors from the list of colors generated by the LightweightThemeManager.

Based on the early WIP by :emilio (https://phabricator.services.mozilla.com/D260879), it looks like the spot to check for forced-colors mode and conditionally not insert theme colors will be LightweightThemeManager._setProperties, here: https://searchfox.org/firefox-main/source/toolkit/modules/LightweightThemeConsumer.sys.mjs#693

We'll want to also add a pref that wraps this change. The pref should be defaulted to true, and wrapped by a Nimbus Variable, so that we can remotely disable it if needed.

Suggested reviewers: emilio and rpl blocking, morgan non-blocking.

Back to Bug 1988635 Comment 0