1988635 - Disable theme colors in forced-colors mode

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

To disable theming in forced-colors mode, we will remove the theme colors from the list of colors generated by the LightweightThemeManager.

Based on the early WIP by :emilio (https://phabricator.services.mozilla.com/D260879), it looks like the spot to check for forced-colors mode and conditionally not insert theme colors will be LightweightThemeManager._setProperties, here: https://searchfox.org/firefox-main/source/toolkit/modules/LightweightThemeConsumer.sys.mjs#693

We'll want to also add a pref that wraps this change. The pref should be defaulted to true, and wrapped by a Nimbus Variable, so that we can remotely disable it if needed.

Suggested reviewers: emilio and rpl blocking, morgan non-blocking.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1988635 - Disable theme colors in forced-colors mode r?emilio!,rpl!,morgan

Comment 2

[Emilio Cobos Álvarez [:emilio]]

You should be able to add some basic tests for this. You did find browser_forced_colors.js which does the right thing.

I think a test that sets a theme, verifies that the lwtheme attribute is set and so on, then forcing forced-colors with:

  await SpecialPowers.pushPrefEnv({
    set: [["ui.useAccessibilityTheme", 1]],
  });

And confirming that:

• The web extension state thinks there's a theme, but.
• The theme is not applied (there's no lwtheme attribute, etc).

Would be at least a decent basic test for this, wdyt?

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sounds great, thanks!

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey emilio - Just a quick ni? ping to take a look at the test added to the patch. Feedback welcome 👍

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Looks good, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2d16349b8d9c
https://hg.mozilla.org/integration/autoland/rev/0e17c1183724
Disable theme colors in forced-colors mode r=morgan,emilio,rpl

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0e17c1183724