There's a handful of dependencies that I think we can remove without losing much and would make the monorepo migration simpler: - `caseless`: Used to perform case-insensitive, unicode-aware, matching for `places`. I think we can just Rust's `to_lowercase()` nowadays. The docs their mention it handles unicode correctly. - `colored`: `mockito` optional subdependency. We can just lose the error messages colors. - `humantime`: This means we lose the timestamps on our CLI tools that print logs. I think we can fix this by updating these tools to use the new code in `tracing_support` and/or `error_support`. - `more-asserts`: used by the logins tests for `assert_ge!`. I think we can switch to using standard macros for this. If needed, we could define our own `assert_ge!`. - `serde_test`: used in the `guid_support` tests. I think we can either remove the test or implement it a different way.
Bug 1988761 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
There's a handful of dependencies that I think we can remove without losing much and would make the monorepo migration simpler: - `caseless`: Used to perform case-insensitive, unicode-aware, matching for `places`. I think we can just Rust's `to_lowercase()` nowadays. The docs their mention it handles unicode correctly. - `colored`: `mockito` optional subdependency. We can just lose the error messages colors. - `humantime`: This means we lose the timestamps on our CLI tools that print logs. I think we can fix this by updating these tools to use the new code in `tracing_support` and/or `error_support`. - `more-asserts`: used by the logins tests for `assert_ge!`. I think we can switch to using standard macros for this. If needed, we could define our own `assert_ge!`. - `serde_test`: used in the `guid_support` tests. I think we can either remove the test or implement it a different way. - `ece`? I'm not totally sure, but it looks like this dependency isn't used anymore.
There's a handful of dependencies that I think we can remove without losing much and would make the monorepo migration simpler: - ~`caseless`: Used to perform case-insensitive, unicode-aware, matching for `places`. I think we can just Rust's `to_lowercase()` nowadays. The docs their mention it handles unicode correctly.~ - `colored`: `mockito` optional subdependency. We can just lose the error messages colors. - `humantime`: This means we lose the timestamps on our CLI tools that print logs. I think we can fix this by updating these tools to use the new code in `tracing_support` and/or `error_support`. - `more-asserts`: used by the logins tests for `assert_ge!`. I think we can switch to using standard macros for this. If needed, we could define our own `assert_ge!`. - `serde_test`: used in the `guid_support` tests. I think we can either remove the test or implement it a different way. - `ece`? I'm not totally sure, but it looks like this dependency isn't used anymore.
There's a handful of dependencies that I think we can remove without losing much and would make the monorepo migration simpler: - ~`caseless`: Used to perform case-insensitive, unicode-aware, matching for `places`. I think we can just Rust's `to_lowercase()` nowadays. The docs their mention it handles unicode correctly.~ - `colored`: `mockito` optional subdependency. We can just lose the error messages colors. - `humantime`: This means we lose the timestamps on our CLI tools that print logs. I think we can fix this by updating these tools to use the new code in `tracing_support` and/or `error_support`. - `more-asserts`: used by the logins tests for `assert_ge!`. I think we can switch to using standard macros for this. If needed, we could define our own `assert_ge!`. - `serde_test`: used in the `guid_support` tests. I think we can either remove the test or implement it a different way. - ~`ece`? I'm not totally sure, but it looks like this dependency isn't used anymore.~