1988761 - Remove app-services dependencies to simplify the monorepo migration

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P2)

Description

[Ben Dean-Kawamura [:bdk]]

There's a handful of dependencies that I think we can remove without losing much and would make the monorepo migration simpler:

• caseless: Used to perform case-insensitive, unicode-aware, matching for places. I think we can just Rust's to_lowercase() nowadays. The docs their mention it handles unicode correctly.
• colored: mockito optional subdependency. We can just lose the error messages colors.
• humantime: This means we lose the timestamps on our CLI tools that print logs. I think we can fix this by updating these tools to use the new code in tracing_support and/or error_support.
• more-asserts: used by the logins tests for assert_ge!. I think we can switch to using standard macros for this. If needed, we could define our own assert_ge!.
• serde_test: used in the guid_support tests. I think we can either remove the test or implement it a different way.
• ece? I'm not totally sure, but it looks like this dependency isn't used anymore.

Comment 1

[Ben Dean-Kawamura [:bdk]]

Let's keep caseless for now. Mark has a patch to vet it and it's not clear if using to_lowercase() will change the behavior or not.

Comment 2

[Ben Dean-Kawamura [:bdk]]

Also, rust-ece is still in use. See https://phabricator.services.mozilla.com/D265023 for a discussion on vetting it.

Comment 3

[BMO Github Automation]

Authored by https://github.com/bendk
https://github.com/mozilla/application-services/commit/235ea58b0a41036e6ede87bb4128a5e6f2015a19
[main] Removing various dependencies that could be hard to move into moz-central. (#6950)