Bug 1993415 Comment 20 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Maksim from comment #18)
> Hello
> I'd publicated patch via phabricator. But i think, probably, including "synchronizeViewWithIME = false," for toolbar->BOTTOM case is enought for fix it without removing part of original code. But i didn't test it. I tested only removing toolbar position checking and BOTTOM case...

(In reply to Kelimutu [:kiki] from comment #15)
> What about the fix, though? Will this make it to the next dot release?

That patch breaks an important functionality for the bottom toolbar:
When the keyboard is animated the bottom toolbar will be animated together with the keyboard - moving up/down, for a smooth animation.
While the website content will jump to the end destination, for avoiding continuous reflows of the web content. 
This functionality is indeed delicate but we'd want to avoid removing it if possible as it has been requested by other users in separate tickets.

If we can get a confirmation that the issue reported in comment 0 has been fixed in the meantime (in Release 144.0.1 / latest Nightly / Beta) then it looks like there's nothing more to do here.
(In reply to Maksim from comment #18)
> Hello
> I'd publicated patch via phabricator. But i think, probably, including "synchronizeViewWithIME = false," for toolbar->BOTTOM case is enought for fix it without removing part of original code. But i didn't test it. I tested only removing toolbar position checking and BOTTOM case...

(In reply to Kelimutu [:kiki] from comment #15)
> What about the fix, though? Will this make it to the next dot release?

The patch attached to this bug breaks an important functionality for the bottom toolbar:
When the keyboard is animated the bottom toolbar will be animated together with the keyboard - moving up/down, for a smooth animation.
While the website content will jump to the end destination, for avoiding continuous reflows of the web content. 
This functionality is indeed delicate but we'd want to avoid removing it if possible as it has been requested by other users in separate tickets.

If we can get a confirmation that the issue reported in comment 0 has been fixed in the meantime (in Release 144.0.1 / latest Nightly / Beta) then it looks like there's nothing more to do here.

Back to Bug 1993415 Comment 20