1993415 - keyboard covers input when toolbar position is bottom

Status: RESOLVED WORKSFORME

(Firefox for Android :: Toolbar, defect)

Description

[Maksim]

User Agent: Mozilla/5.0 (Android 16; Mobile; rv:145.0) Gecko/145.0 Firefox/145.0

Steps to reproduce:

Set toolbar position bottom
Visit some site with text input field in bottom.
Tup to input field

Actual results:

Keyboard covers input field.

Expected results:

Content of site sould move to top on keyboard height.

Comment 1

[Maksim]

I can suggest patch because i solved this bug locally.

Comment 2

[Maksim]

Just mark me as Assignee and i will commit solution

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Maksim]

Attachment: 1993415_fix.patch

Old code needs toolbar position checking. Old code trying move up toolbar separately from view. But toolbar is in view and when view moves up, all content move up with it. Checking not need.

Comment 5

[Roger Yang [:royang]]

Thanks for reporting this issue and suggesting a patch. Do you want to submit the patch via https://phabricator.services.mozilla.com/?
Here is the guide: phabricator user guide

If not I can investigate/test and push the patch for you. Please let me know your preference.

Comment 6

[Maksim]

I will try to submit it. If something will wrong i will report you. Thanks

Comment 7

[gajbooks]

Just going to comment on the severity of this issue. This problem is new, and intensely frustrating.

A reasonable workaround to maintain usability is to use the top address bar mode, which works correctly.

Pixel 8a, Android 16, Firefox 144.0.1 (Build #2016119303)

Seems to be a regression introduced here https://phabricator.services.mozilla.com/D266766

Comment 8

[Maksim]

Attachment: Bug: 1993415. I had removed toolbar position checking and disabled synchronizeViewWithIME

I had removed toolbar position checking and disabled synchronizeViewWithIME because it works incorrect in this case. I didn't inspect synchronizeViewWithIME.
it seems like old code trying to move toolbar separately from view but toolbar is in view and when keyboard showing up, view moves up and toolbar too, because toolbar is in view. I don't know why somebody added synchronizeViewWithIME for it.

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9520891 [details]
Bug: 1993415. I had removed toolbar position checking and disabled synchronizeViewWithIME

Changing the target repo of the patch to autoland and removing release uplift request flag.
The patch should land on autoland first
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Comment 10

[Kelimutu [:kiki]]

@Donal we see an increase of people asking about this in SUMO. Will the fix for this make it to the upcoming dot release?

Comment 12

[Donal Meehan [:dmeehan]]

(In reply to Kelimutu [:kiki] from comment #10)

@Donal we see an increase of people asking about this in SUMO. Will the fix for this make it to the upcoming dot release?

:kiki the bugs you linked in See also were all duplicates of Bug 1992740. Bug 1992740 has been fixed and shipped in Fenix 144.0.1

Comment 13

[Maksim]

(In reply to Donal Meehan [:dmeehan] from comment #9)

Comment on attachment 9520891 [details]
Bug: 1993415. I had removed toolbar position checking and disabled synchronizeViewWithIME

Changing the target repo of the patch to autoland and removing release uplift request flag.
The patch should land on autoland first
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Hello
Thanks for your help. What do you thing about my patch? I think, probably, including "synchronizeViewWithIME = false," for toolbar->BOTTOM case is enought for fix it without removing part of original code. But i didn't test it. I tested only removing toolbar position checking and BOTTOM case...

Comment 14

[Maksim]

Anyway i don't understand why toolbar position checking is there.

Comment 15

[Kelimutu [:kiki]]

(In reply to Donal Meehan [:dmeehan] from comment #12)

:kiki the bugs you linked in See also were all duplicates of Bug 1992740. Bug 1992740 has been fixed and shipped in Fenix 144.0.1
Oopsie. Thanks for clarifying.

What about the fix, though? Will this make it to the next dot release?

Comment 16

[Donal Meehan [:dmeehan]]

(In reply to Maksim from comment #13)

(In reply to Donal Meehan [:dmeehan] from comment #9)

Comment on attachment 9520891 [details]
Bug: 1993415. I had removed toolbar position checking and disabled synchronizeViewWithIME

Changing the target repo of the patch to autoland and removing release uplift request flag.
The patch should land on autoland first
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Hello
Thanks for your help. What do you thing about my patch? I think, probably, including "synchronizeViewWithIME = false," for toolbar->BOTTOM case is enought for fix it without removing part of original code. But i didn't test it. I tested only removing toolbar position checking and BOTTOM case...

redirecting request to :royang, as a follow on from Comment 5

Comment 17

[Donal Meehan [:dmeehan]]

(In reply to Kelimutu [:kiki] from comment #15)

(In reply to Donal Meehan [:dmeehan] from comment #12)

:kiki the bugs you linked in See also were all duplicates of Bug 1992740. Bug 1992740 has been fixed and shipped in Fenix 144.0.1
Oopsie. Thanks for clarifying.

What about the fix, though? Will this make it to the next dot release?

Bug 1992740 was shipped in 144.0.1 and is live at 100% rollout

Comment 18

[Maksim]

(In reply to Roger Yang [:royang] from comment #5)

Thanks for reporting this issue and suggesting a patch. Do you want to submit the patch via https://phabricator.services.mozilla.com/?
Here is the guide: phabricator user guide

If not I can investigate/test and push the patch for you. Please let me know your preference.

Hello
I'd publicated patch via phabricator. But i think, probably, including "synchronizeViewWithIME = false," for toolbar->BOTTOM case is enought for fix it without removing part of original code. But i didn't test it. I tested only removing toolbar position checking and BOTTOM case...

Comment 19

[Petru-Mugurel Lingurar [:petru]]

I think this was fixed by bug 1992740.
I cannot reproduce in either 144.0.1 or the latest Nightly.
@Maksim / QA Can you confirm if this has been fixed or is still reproduceable?

Comment 20

[Petru-Mugurel Lingurar [:petru]]

(In reply to Maksim from comment #18)

Hello
I'd publicated patch via phabricator. But i think, probably, including "synchronizeViewWithIME = false," for toolbar->BOTTOM case is enought for fix it without removing part of original code. But i didn't test it. I tested only removing toolbar position checking and BOTTOM case...

(In reply to Kelimutu [:kiki] from comment #15)

What about the fix, though? Will this make it to the next dot release?

The patch attached to this bug breaks an important functionality for the bottom toolbar:
When the keyboard is animated the bottom toolbar will be animated together with the keyboard - moving up/down, for a smooth animation.
While the website content will jump to the end destination, for avoiding continuous reflows of the web content.
This functionality is indeed delicate but we'd want to avoid removing it if possible as it has been requested by other users in separate tickets.

If we can get a confirmation that the issue reported in comment 0 has been fixed in the meantime (in Release 144.0.1 / latest Nightly / Beta) then it looks like there's nothing more to do here.

Comment 21

[Roger Yang [:royang]]

Comment on attachment 9519432 [details] [diff] [review]
1993415_fix.patch

Review of attachment 9519432 [details] [diff] [review]:
-----------------------------------------------------------------

Changes are now reviewed in phabricator.

Comment 22

[Adina Petridean QA [:apetridean]]

Attachment: Screenshot_20251029_163756_Firefox Nightly (1).jpg

This issue is not reproducible on the latest Nightly 146.0a1, Fenix 145.0b7 and RC 144.02 using Moto G72 (Android 13) and Samsung Galaxy S23 Ultra (Android 14).

Comment 23

[Adina Petridean QA [:apetridean]]

.

Comment 24

[Adina Petridean QA [:apetridean]]

Attachment: Screenshot_20251029_164515_Firefox Nightly.jpg

Comment 25

[BugBot [:suhaib / :marco]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:royang, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 26

[Petru-Mugurel Lingurar [:petru]]

Closing as fixed by bug 1992740.