Bug 1994013 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Mimic the current functionality of querying passed-in autocomplete providers for autocompletions for the current input.
It's still preferable to handle querying and setting autocompletions at the toolbar level because of the delay that going through the MVI loop would bring.

Among functionalities needed:
- updating the autocompletions when the query changes, 
- removing them when user presses back or changes cursor position
- announce the autocompleted URL to accessibility services
Mimic the current functionality of querying passed-in autocomplete providers for autocompletions for the current input.
~It's still preferable to handle querying and setting autocompletions at the toolbar level because of the delay that going through the MVI loop would bring.~
Testing more it seems like going through the MVI loop: 
> emit text updates from the toolbar -> infer autocomplete suggestions in the middleware -> update the toolbar with the inline autocomplete suggestion 

has just a small performance penalty while the code architecture is greatly improved so we should include this updated flow in the refactor.

Among functionalities needed:
- updating the autocompletions when the query changes, 
- removing them when user presses back or changes cursor position
- announce the autocompleted URL to accessibility services

Back to Bug 1994013 Comment 0