1994013 - Show inline autocompletions when handling toolbar input in a composable

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Mimic the current functionality of querying passed-in autocomplete providers for autocompletions for the current input.
It's still preferable to handle querying and setting autocompletions at the toolbar level because of the delay that going through the MVI loop would bring.
Testing more it seems like going through the MVI loop:

emit text updates from the toolbar -> infer autocomplete suggestions in the middleware -> update the toolbar with the inline autocomplete suggestion

has just a small performance penalty while the code architecture is greatly improved so we should include this updated flow in the refactor.

Among functionalities needed:

• updating the autocompletions when the query changes,
• removing them when user presses back or changes cursor position
• announce the autocompleted URL to accessibility services

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1994013 - New composable to support entering text in the composable toolbar r=#android-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd71d9a75c3b
https://hg.mozilla.org/integration/autoland/rev/db94a76a5d3f
New composable to support entering text in the composable toolbar r=android-reviewers,Roger

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/db94a76a5d3f

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1994013 - New composable to support entering text in the composable toolbar

This also allowed to move the complex logic of querying different autocomplete
providers for the suggestion to show as inline autocompletion logic to
integrators like Fenix while having the new composable only responsible for how
to how the received suggestion.

Original Revision: https://phabricator.services.mozilla.com/D268687

Comment 5

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c9df7dd36664
https://hg.mozilla.org/releases/mozilla-release/rev/f63b87a27f55