Hi Cristina! Thanks for flagging the failures. I took a closer look and the test failures appear to be unrelated to my patch - they're all DOMLocalization errors with sitedata-total-size-calculating: undefined happening in site data/privacy tests like browser_clearSiteData_v2.js and browser_sanitizeDialog_v2.js. My patch only touches the AI features preferences panel, so it shouldn't affect any of the site data l10n handling. This looks like it might be a known intermittent that's been popping up in other patches too. I've pushed another try with a fix for the manage button ID collision. Lets see how this one goes! Meanwhile please let me know if you need anything else from me. Thanks!
Bug 2001453 Comment 13 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Hi Cristina! Thanks for flagging the failures. I took a closer look and the test failures appear to be unrelated to my patch - they're all DOMLocalization errors with sitedata-total-size-calculating: undefined happening in site data/privacy tests like browser_clearSiteData_v2.js and browser_sanitizeDialog_v2.js. My patch only touches the AI features preferences panel, so it shouldn't affect any of the site data l10n handling. This looks like it might be a known intermittent that's been popping up in other patches too. I've pushed another try with a fix for the manage button ID collision. Lets see how this one goes! Meanwhile please let me know if you need anything else from me. Thanks!
Hi Cristina! Thanks for flagging the failures. the sitedata-total-size-calculating error was actually caused by my patch, not an intermittent. The issue was a change in setting-control.mjs: `let config = this.setting.getControlConfig(this.config);` Reverting this back to the original fixes it. I've confirmed the test passes locally with the revert. Once the current version is backed out, I'll resubmit with the fix. Thanks for your patience!