2001453 - [Memories] List all aggregated memories added in a given chat session

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, task)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to implement a web component that can be used to list all aggregated insights in a chat inside Insight panel.

Figma

PRD

Update: On Hold waiting for final designs managing insights under settings

Comment 1

[Punam Dahiya [:pdahiya]]

Till we are ready to call this component inside AI Window , we can use Smart Assist UI to surface this component

Comment 2

[Chloe Zhou [:chloezhou]]

Attachment: WIP: Bug 2001453 - List all aggregated insights added in a given chat session

Comment 3

[Chloe Zhou [:chloezhou]]

Attachment: Bug 2001453 - Add Manage memories UI to Smart Window preferences r=mardak,yjamora

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e331c50ee671
https://hg.mozilla.org/integration/autoland/rev/1faaa0735914
Add Manage memories UI to Smart Window preferences r=Mardak,fluent-reviewers,hjones,ai-ondevice-reviewers,bolsson DONTBUILD

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e8abbd1928f0
https://hg.mozilla.org/integration/autoland/rev/4ec83a4841e2
Revert "Bug 2001453 - Add Manage memories UI to Smart Window preferences r=Mardak,fluent-reviewers,hjones,ai-ondevice-reviewers,bolsson DONTBUILD" for causing bc failures DOMLocalization related

Comment 8

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures DOMLocalization related

Backout link

Push with failures

Failure log
Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b892ee4ad795
https://hg.mozilla.org/integration/autoland/rev/9d74297f655b
Add Manage memories UI to Smart Window preferences r=Mardak,fluent-reviewers,hjones,ai-ondevice-reviewers,bolsson

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a3efdae721f
https://hg.mozilla.org/integration/autoland/rev/66722f9ea10d
Revert "Bug 2001453 - Add Manage memories UI to Smart Window preferences r=Mardak,fluent-reviewers,hjones,ai-ondevice-reviewers,bolsson" for causing bc failures on DOMLocalization

Comment 11

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on DOMLocalization

Backout link

Push with failures

Failure log
Failure log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/73ce58271417
https://hg.mozilla.org/integration/autoland/rev/bd18adfe585a
Add Manage memories UI to Smart Window preferences r=Mardak,fluent-reviewers,hjones,ai-ondevice-reviewers,bolsson

Comment 13

[Chloe Zhou [:chloezhou]]

Hi Cristina!
Thanks for flagging the failures. the sitedata-total-size-calculating error was actually caused by my patch, not an intermittent.
The issue was a change in setting-control.mjs: let config = this.setting.getControlConfig(this.config);

Reverting this back to the original fixes it. I've confirmed the test passes locally with the revert. Once the current version is backed out, I'll resubmit with the fix. Thanks for your patience!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4d28b9d239a
https://hg.mozilla.org/integration/autoland/rev/e6784795a59e
Revert "Bug 2001453 - Add Manage memories UI to Smart Window preferences r=Mardak,fluent-reviewers,hjones,ai-ondevice-reviewers,bolsson" for causing multiple mochitests failures.

Comment 15

[Serban Stanca [:SerbanS]]

Reverted this because it was causing multiple mochitests failures.

• Revert link

---

• Push with failures - some mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/siteData/browser_clearSiteData_v2.js | testSiteDataClearing - A promise chain failed to handle a rejection: DOMLocalization.translateFragment: [dom/l10n] Failed to parse l10n-args JSON (sitedata-total-size-calculating): undefined - stack: update@chrome://global/content/lit-utils.mjs:223:18

---

• Push with failures - another mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/contextualidentity/test/browser/browser_originattrs_reopenin.js | testReopen - A promise chain failed to handle a rejection: DOMLocalization.translateFragment: [dom/l10n] Failed to parse l10n-args JSON (sitedata-total-size-calculating): undefined - stack: update@chrome://global/content/lit-utils.mjs:223:18

---

• Push with failures - another mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js | test_pref_remembering - A promise chain failed to handle a rejection: DOMLocalization.translateFragment: [dom/l10n] Failed to parse l10n-args JSON (sitedata-total-size-calculating): undefined - stack: update@chrome://global/content/lit-utils.mjs:223:18

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0e2a5ea1a0e2
https://hg.mozilla.org/integration/autoland/rev/89fde3c2fddd
Add Manage memories UI to Smart Window preferences r=Mardak,fluent-reviewers,hjones,ai-ondevice-reviewers,bolsson

Comment 17

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/89fde3c2fddd

Comment 18

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 149.0b1