Bug 2016758 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Bug 2008977 got the smart bar drop-down working in Smart Window.  I've marked it as "regressing" that bug, but it's only a regression in the sense of displaying the warning to the console, since before that landing, it wasn't even possible to get the smartbar to drop down at all.

Now that it's working, after each typed keystroke that matches something, this shows up multiple times in the Browser Console: 

```
console.error: (new TypeError("can't access property \"announce\", this.window.A11yUtils is undefined", "moz-src:///browser/components/urlbar/UrlbarView.sys.mjs", 854))
```

which suggests that voice accessibility isn't yet working (though I haven't verified that).  Fallout includes additional code that probably isn't executing because of the exception.

Doing this in the constructor:

```
    if (!this.window.A11yUtils) {
      this.window.A11yUtils =
        this.window.browsingContext.topChromeWindow.A11yUtils;
    }
```
causes the error message to go away, and if there's code not executing that should be, that change likely fixes it. But reaching across from content to chrome like this (in the SmartBar) case seems icky and possibly fragile.  I wonder if we want
Bug 2008977 got the smart bar drop-down working in Smart Window.  I've marked it as "regressing" that bug, but it's only a regression in the sense of displaying the warning to the console, since before that landing, it wasn't even possible to get the smartbar to drop down at all.

Now that it's working, after each typed keystroke that matches something, this shows up multiple times in the Browser Console: 

```
console.error: (new TypeError("can't access property \"announce\", this.window.A11yUtils is undefined", "moz-src:///browser/components/urlbar/UrlbarView.sys.mjs", 854))
```

which suggests that voice accessibility isn't yet working (though I haven't verified that).  Fallout includes additional code that probably isn't executing because of the exception.

Doing this in the UrlbarView constructor:

```
    if (!this.window.A11yUtils) {
      this.window.A11yUtils =
        this.window.browsingContext.topChromeWindow.A11yUtils;
    }
```
causes the error message to go away, and if there's code not executing that should be, that change likely fixes it. But reaching across from content to chrome like this (in the SmartBar) case seems icky and likely fragile.  I wonder if we want something Actor-based here...
Bug 2008977 got the smart bar drop-down working in Smart Window.  I've marked it as "regressing" that bug, but it's only a regression in the sense of displaying the warning to the console, since before that landing, it wasn't even possible to get the smartbar to drop down at all.

Now that it's working, after each typed keystroke that matches something, this shows up multiple times in the Browser Console: 

```
console.error: (new TypeError("can't access property \"announce\", this.window.A11yUtils is undefined", "moz-src:///browser/components/urlbar/UrlbarView.sys.mjs", 854))
```

which suggests that voice accessibility isn't yet working (though I haven't verified that).  Fallout includes additional code that probably isn't executing because of the exception.

Doing this in the UrlbarView constructor:

```
    if (!this.window.A11yUtils) {
      this.window.A11yUtils =
        this.window.browsingContext.topChromeWindow.A11yUtils;
    }
```
causes the error message to go away, and if there's code not executing that should be, that change likely fixes it. But reaching across from content to chrome like this (in the SmartBar case) seems icky and likely fragile.  I wonder if we want something Actor-based here...

Back to Bug 2016758 Comment 0