Closed Bug 2008977 (smartbar-suggestions) Opened 4 months ago Closed 2 months ago

Adapt position of Smartbar search suggestions list for the AI Window sidebar

Categories

(Core :: Machine Learning: Frontend, task)

Product:
Core
Component:
Machine Learning: Frontend
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
149 Branch
Tracking Flags:
Tracking Status
firefox149 --- verified

People

(Reporter: flozia, Assigned: flozia)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [genai][input])

Attachments

(1 file)

Bug 2008977 - Show Smartbar suggestions view
48 bytes, text/x-phabricator-request
Details | Review

The default position of the search suggestions list for the Smartbar is below the input. For the AI Window sidebar (or when there is not enough space beneath) we need to be able to show the list above the input.

This patch shows the Urlbar suggestions view for the Smartbar. Depending on where the Smartbar is shown, fullpage or in the sidebar, the list of suggestions can be either below or above the input. The suggestions are only supposed to show for the first interaction with the Smartbar and won’t show for consecutive chat turns.

Assignee: nobody → fzia
Attachment #9541417 - Attachment description: WIP: Bug 2008977 - Show Smartbar suggestions view → Bug 2008977 - Show Smartbar suggestions view
Status: NEW → ASSIGNED
Alias: smartbar-suggestions
Blocks: 2016191
Blocks: 2016098
Blocks: 2015094
Pushed by elee@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/202d6647a5c1 https://hg.mozilla.org/integration/autoland/rev/49ebbe7fef06 Show Smartbar suggestions view r=desktop-theme-reviewers,urlbar-reviewers,ai-frontend-reviewers,mak,dmose,dao

https://hg.mozilla.org/mozilla-central/rev/49ebbe7fef06

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox149: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
Blocks: 2015118
Regressions: 2016914
Blocks: 2016912
Blocks: 2017488
Blocks: 2017089
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49]
QA Contact: rdoghi
Duplicate of this bug: 2015094

Verified as fixed in our latest Beta 149.0b1

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49] → [qa-triage-done-c150/b149] [qa-ver-done-c150/b49]
status-firefox149: fixed → verified
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-done-c150/b49] → [qa-triage-done-c150/b149] [qa-ver-done-c150/b149]
Blocks: 2017971
Blocks: 2022457
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: