(In reply to James Graham [:jgraham] from comment #68) > honestly I'm not sure what this bug is supposed to cover that isn't covered by https://bugzilla.mozilla.org/show_bug.cgi?id=308403 Per comment 12 and the patch attached there, it looks like Mats intended to address `min-width/min-height` on this bug, and he spun off bug 308403 as a followup to cover `max-width/max-height` since his patch didn't handle those. That patch from comment 12 never seems to have landed, though. We also may have fixed this (or most/much of this) at various points over the years, though? It certainly looks like we're honoring `min-height` on `table` in the 1st testcase here, and `min-width` on `td` in the 3rd testcase, for example. I do see we have bug 1651530 as an explicit dependency that fixed up some of this, too. Per dbaron's comment 45, it's not particularly useful at this point to have this one bug covering a host of different {min/max}-{height/width} use cases, especially now that we've made progress on fixing some of them, and others of them are interoperably ignored in all browser engines. Looking at the attached testcases, it seems we're almost entirely interoperable with Chrome except for one case in the 3rd testcase where we *do* honor `min-width` and they do not; and we're almost entirely interoperable with WebKit except for that same case, plus some cases where WebKit ignores `height` on `tbody`. Specific results on the testcases here: * `TABLE min-height`: We match WebKit/Chromium * `TR min-height`: We match WebKit/Chromium * `TD min-width/height`: We match WebKit/Chromium, except for the last three lines where we're honoring the `min-width:80%` on the first 2 and Chrome/WebKit are not (I guess they don't support percent min-width on cells?) * `TBODY min-height`: We match WebKit/Chromium in ignoring the `min-height` on the tbody there. (WebKit renders one table as shorter than Chrome/Firefox, due to them also ignoring `height` on tbody, it seems.) * `TBODY max-height`: We match Chromium/WebKit in ignoring the max-height there. (As in the previous testcase: WebKit renders one table as shorter than Chrome/Firefox, due to them also ignoring `height` on tbody, it seems.) So I think we can close this as WFM.
Bug 307866 Comment 69 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to James Graham [:jgraham] from comment #68) > honestly I'm not sure what this bug is supposed to cover that isn't covered by https://bugzilla.mozilla.org/show_bug.cgi?id=308403 Per comment 12 and the patch attached there, it looks like Mats intended to address `min-width/min-height` on this bug, and he spun off bug 308403 as a followup to cover `max-width/max-height` since his patch didn't handle those. That patch from comment 12 never seems to have landed, though. We also may have fixed this (or most/much of this) at various points over the years, though? It certainly looks like we're honoring `min-height` on `table` in the 1st testcase here, and `min-width` on `td` in the 3rd testcase, for example. I do see we have bug 1651530 as an explicit dependency that fixed up some of this, too. Per dbaron's comment 45, it's not particularly useful at this point to have this one bug covering a host of different {min/max}-{height/width} use cases, especially now that we've made progress on fixing some of them, and others of them are interoperably ignored in all browser engines. Looking at the attached testcases, it seems we're almost entirely interoperable with Chrome except for one case in the 3rd testcase where we *do* honor `min-width` and they do not; and we're almost entirely interoperable with WebKit except for that same case, plus some cases where WebKit ignores `height` on `tbody`. Specific results on the testcases here: * `TABLE min-height`: We match WebKit/Chromium * `TR min-height`: We match WebKit/Chromium * `TD min-width/height`: We match WebKit/Chromium, except for the last three lines where we render the three lines the same width and Chrome/WebKit do not (we're honoring the `min-width:80%` on the first 2 and Chrome/WebKit are not; I guess they don't support percent min-width on cells?) * `TBODY min-height`: We match WebKit/Chromium in ignoring the `min-height` on the tbody there. (WebKit renders one table as shorter than Chrome/Firefox, due to them also ignoring `height` on tbody, it seems.) * `TBODY max-height`: We match Chromium/WebKit in ignoring the max-height there. (As in the previous testcase: WebKit renders one table as shorter than Chrome/Firefox, due to them also ignoring `height` on tbody, it seems.) So I think we can close this as WFM.